Skip to content

Commit

Permalink
_initialWopiFileInfo is never set
Browse files Browse the repository at this point in the history
Signed-off-by: Caolán McNamara <[email protected]>
Change-Id: I5c90b48629c52cf4db76a174c15470d9e48294d4
  • Loading branch information
caolanm committed Nov 21, 2024
1 parent 9a8f66b commit d181e89
Show file tree
Hide file tree
Showing 2 changed files with 0 additions and 28 deletions.
24 changes: 0 additions & 24 deletions wsd/DocumentBroker.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -314,30 +314,6 @@ void DocumentBroker::pollThread()

setupPriorities();

// Download and load the document.
if (_initialWopiFileInfo)
{
try
{
downloadAdvance(_childProcess->getJailId(), _uriPublic, std::move(_initialWopiFileInfo));
}
catch (const std::exception& exc)
{
LOG_ERR("Failed to advance download [" << _docKey << "]: " << exc.what());

stop("advance download failed");

// Stop to mark it done and cleanup.
_poll->stop();

// Async cleanup.
COOLWSD::doHousekeeping();

return;
}
}


#if !MOBILEAPP
CONFIG_STATIC const std::size_t IdleDocTimeoutSecs =
ConfigUtil::getConfigValue<int>("per_document.idle_timeout_secs", 3600);
Expand Down
4 changes: 0 additions & 4 deletions wsd/DocumentBroker.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -1406,10 +1406,6 @@ class DocumentBroker : public std::enable_shared_from_this<DocumentBroker>
std::string _filename;
std::atomic<bool> _migrateMsgReceived = false;

/// The WopiFileInfo of the initial request loading the document for the first time.
/// This has a single-use, and then it's reset.
std::unique_ptr<WopiStorage::WOPIFileInfo> _initialWopiFileInfo;

/// The state of the document.
/// This regulates all other primary operations.
class DocumentState final
Expand Down

0 comments on commit d181e89

Please sign in to comment.