Private/mmeeks/pollclean #10333
Merged
Private/mmeeks/pollclean #10333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Michael Meeks <[email protected]> Change-Id: I9b998b1934b67c800acd5c41f5d43973fbc20c10
Restores exception guards reduces duplication simplifies code - to use existing disposition logic. fixes unusual branch on function whitespace removes logged warning on timeout removes timeout handling from 'checkRemoval' - timeout does not imply removal; return value needs re-evaluating there. restores checkTimeout in its original location.i - unclear what extra 'setClosed' is good for. also removes 'checkRemoval' from ServerSocket sub-class etc. Signed-off-by: Michael Meeks <[email protected]> Change-Id: Ibb582ec5b2600c7ac7cf3b6aecbee39c43b214f8
Ashod
approved these changes
Oct 26, 2024
| @@ -1505,13 +1505,13 @@ bool StreamSocket::checkRemoval(std::chrono::steady_clock::time_point now) | |||
| const auto durLast = | |||
| std::chrono::duration_cast<std::chrono::milliseconds>(now - getLastSeenTime()); | |||
| /// TO Criteria: Violate maximum idle (_pollTimeout default 64s) | |||
| const bool isIDLE = _pollTimeout > std::chrono::microseconds::zero() && | |||
| durLast > _pollTimeout; | |||
| const bool isIdle = _pollTimeout > std::chrono::microseconds::zero() && | |||
There was a problem hiding this comment.
Yes, more than a couple of capitalized letters and it fast becomes obnoxious.
sgothel
approved these changes
Oct 26, 2024
There was a problem hiding this comment.
With this re-org virtual Socket::checkRemoval can be removed and StreamSocket::checkRemoval a plain method.
I can add this on top.
As discussed, if SigUtil::getTerminationFlag() checkRemoval
should indeed closeConnection() right away to be save,
as polling might be stopped as in TerminatingPoll or kitPoll().
Looks great.
|
Kicked jenkins .. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
TODO
Checklist
make prettier-writeand formatted the code.make checkmake runand manually verified that everything looks okay