Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

browser: slideshow: open presenter in secondary screen #10460

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

hcvcastro
Copy link
Member

Change-Id: Ifa0410075ceb25b01797f6219356adc184a74b31
Signed-off-by: Henry Castro [email protected]

Change-Id: Ifa0410075ceb25b01797f6219356adc184a74b31
Signed-off-by: Henry Castro <[email protected]>
// if the device has more than one screen.
if ((window.screen as any).isExtended) {
const details = await (window as any).getScreenDetails();
const secondary = details.screens.find(function (s: any) {

Check notice

Code scanning / CodeQL

Unused variable, import, function or class Note

Unused variable secondary.
return s !== s.primaryScreen;
});
options +=
'left=${secondary.availLeft},' +

Check warning

Code scanning / CodeQL

Template syntax in string literal Warning

This string is not a template literal, but appears to reference the variable
secondary
.
});
options +=
'left=${secondary.availLeft},' +
'top=${secondary.availTop},' +

Check warning

Code scanning / CodeQL

Template syntax in string literal Warning

This string is not a template literal, but appears to reference the variable
secondary
.
options +=
'left=${secondary.availLeft},' +
'top=${secondary.availTop},' +
'width=${secondary.availWidth},' +

Check warning

Code scanning / CodeQL

Template syntax in string literal Warning

This string is not a template literal, but appears to reference the variable
secondary
.
'left=${secondary.availLeft},' +
'top=${secondary.availTop},' +
'width=${secondary.availWidth},' +
'height=${secondary.availHeight}';

Check warning

Code scanning / CodeQL

Template syntax in string literal Warning

This string is not a template literal, but appears to reference the variable
secondary
.
@eszkadev
Copy link
Contributor

is this still in progress?

it has conflict which has to be resolved first

@hcvcastro
Copy link
Member Author

No, it does not. It is still experimental draft and pause. I do not know when I will resume the task

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: To Review
Development

Successfully merging this pull request may close these issues.

2 participants