Refactor Ruler class to centralize common functionality and enforce subclass implementation #10907
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Darshan-upadhyay1110
force-pushed
the
private/darshan/ruler-typescript-conversion
branch
3 times, most recently
from
9fb352d to
9def96f
Compare
Darshan-upadhyay1110
force-pushed
the
private/darshan/ruler-typescript-conversion
branch
2 times, most recently
from
177456e to
766617b
Compare
caolanm
force-pushed
the
private/darshan/ruler-typescript-conversion
branch
from
766617b to
01ff76c
Compare
gokaysatir
reviewed
Jan 14, 2025
browser/Makefile.am
Outdated
| src/control/VRuler.ts \ | ||
| src/control/HRuler.ts \ | ||
| src/control/Ruler.ts \ |
There was a problem hiding this comment.
Why do we have 2 of these?
gokaysatir
reviewed
Jan 14, 2025
| src/control/Signing.js \ | ||
| src/control/Toolbar.js \ | ||
| src/control/VRuler.ts \ | ||
| src/control/Ruler.ts \ |
There was a problem hiding this comment.
It's the same here, why duplicate?
|
Works well, thanks @Darshan-upadhyay1110 :) Don't know why that test is failing. Maybe a rebase could work? |
Darshan-upadhyay1110
force-pushed
the
private/darshan/ruler-typescript-conversion
branch
from
01ff76c to
6a59100
Compare
gokaysatir
approved these changes
Jan 15, 2025
Darshan-upadhyay1110
force-pushed
the
private/darshan/ruler-typescript-conversion
branch
from
6a59100 to
8b5d792
Compare
…ubclass implementation - Converted ruler file into typescript - created base class and subclass for Horizontal and vertical ruler - Moved the `_updatePaintTimer` method to the base `Ruler` class to avoid duplication across `HRuler` and `VRuler`. - Added `_updateBreakPoints` as an abstract-like method in the base class, throwing an error to enforce implementation in subclasses. - Streamlined the initialization logic in `Ruler.initializeRuler` for better readability and modularity. Signed-off-by: Darshan-upadhyay1110 <[email protected]> Change-Id: I8f0187588ffab533e135023285acb3dcada832d4
- Change overflow from hidden to overflow-x: clip to ensure horizontal ruler visibility. - Prevent vertical ruler overflow beyond parent container when zoomed in. - Resolve misalignment when the tab container has custom or transparent background. Signed-off-by: Darshan-upadhyay1110 <[email protected]> Change-Id: I43e52f248ba4d4a9fc86d9ba347de776a0894334
Darshan-upadhyay1110
force-pushed
the
private/darshan/ruler-typescript-conversion
branch
from
8b5d792 to
9096d51
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_updatePaintTimermethod to the baseRulerclass to avoid duplication acrossHRulerandVRuler._updateBreakPointsas an abstract-like method in the base class, throwing an error to enforce implementation in subclasses.Ruler.initializeRulerfor better readability and modularity.Change-Id: I8f0187588ffab533e135023285acb3dcada832d4
Summary
TODO
Checklist
make prettier-writeand formatted the code.make checkmake runand manually verified that everything looks okay