Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kill saving thread with SIGABRT #10908

Merged
merged 1 commit into from
Jan 13, 2025
Merged

Conversation

caolanm
Copy link
Contributor

@caolanm caolanm commented Jan 10, 2025

so the the correct/main thread gets the signal so we can get a backtrace generated.

Change-Id: I64f8f374bad92964f42ba34e23011bf827d87bf9

  • Resolves: #
  • Target version: master

Summary

TODO

  • ...

Checklist

  • I have run make prettier-write and formatted the code.
  • All commits have Change-Id
  • I have run tests with make check
  • I have issued make run and manually verified that everything looks okay
  • Documentation (manuals or wiki) has been updated or is not required

so the the correct/main thread gets the signal so we can get a backtrace
generated.

Signed-off-by: Caolán McNamara <[email protected]>
Change-Id: I64f8f374bad92964f42ba34e23011bf827d87bf9
@caolanm caolanm force-pushed the private/caolan/kill_save_with_SIGABRT branch from af37080 to 998b82a Compare January 10, 2025 21:18
@caolanm caolanm requested a review from mmeeks January 13, 2025 08:54
@caolanm
Copy link
Contributor Author

caolanm commented Jan 13, 2025

We already have a killThreadById(int tid, int signal which is ::syscall(SYS_tgkill, getpid(), tid, signal);

With this patch and a long enough sleep in core to make this happens, then bt is the wanted thread:

kit-2007983-2008056 2025-01-13 08:50:43.332141 +0000 [ kitbgsv_002_001 ] SIG   Fatal signal received: SIGABRT code: 18446744073709551610 for address: 0x3e8001ea3f8
...
Backtrace 2008056 - kit startup of 24.04.12.0 87a2a7f3c2:
/home/caolan/LibreOffice/collabora-online/coolforkit-ns(_ZN7SigUtil13dumpBacktraceEv+0x71)[0x5377f1]
/home/caolan/LibreOffice/collabora-online/coolforkit-ns[0x537c25]
/lib64/libc.so.6(+0x40d00)[0x7f69e724fd00]
/lib64/libc.so.6(clock_nanosleep+0x63)[0x7f69e72f2c13]
/lib64/libc.so.6(nanosleep+0x17)[0x7f69e72fec47]
/lib64/libc.so.6(sleep+0x41)[0x7f69e73112b1]
/home/caolan/LibreOffice/co-24.04/instdir/program/libmergedlo.so(+0x31d4c64)[0x7f69de5d4c64]

Copy link
Contributor

@mmeeks mmeeks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful; thanks Caolan @timar can we get this back-ported into a green update and get it running on various servers ? =) would like to get the the root cause of bgsave problems =)

@mmeeks mmeeks merged commit ac743d3 into master Jan 13, 2025
14 checks passed
@mmeeks mmeeks deleted the private/caolan/kill_save_with_SIGABRT branch January 13, 2025 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants