-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
update general/conflux-basics/gas.md, regarding the issue #451 #453
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your pull request. There are some changes needed before this pull request could get merged.
- The position where the content is inserted. Currently the new part is inserted into between
How gasFee is calculated
and the subsectiongasUsed
. It is supposed to move somewhere else to retain context consistency
- the second point and third point are referring the same thing ---- sponsorship mechanism. And I don't think this is the suitable contents here. From the user's perspective, he has hardly choice making use of the sponsorship mechanism or not. And from developers' perspective, the developer did not pay less.
- The header "How do I pay less gas?" should be changed. For example, "How can users pay less gas fee?". And relating contents can be illustrated from user's or developer's perspective, for example, optimizing contract logic, using multicall, etc
Made some changes as per your tips |
The modified content is good! And for the current content, I think it would be better to be listed as an individual article because the pages in Another question is the a series of tutorials for gas optimization. I guess you are going to create detailed tutorials, for example, illustrate the mechanism and giving an example on how to use libraries. In that case that would be awesome. But it is also a choice that you only contain the most important key points in a single article. But anyway it depends on you. |
docs/general/build/smart-contracts/introduction-to-smart-contracts.md
Outdated
Show resolved
Hide resolved
I made some more modifications according to your suggestions and made some improvements for Issue #454. After that, I will gradually add detailed tutorials on gas optimization. If time permits, I will use my free time to add a tutorial every day. |
I think after the above minor change, the current content is ready to be merged. Would you like to be merged immediately or after all the relating gas optimization tutorials are ready? |
…acts.md Co-authored-by: darwintree <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
thanks, bro |
Pre-flight checklist
This change is