Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refs #509 -- Added a tutorial to introduce how to cross-space CRC20 token to eSpace #592

Merged
merged 7 commits into from
Jun 12, 2024

Conversation

jackleeio
Copy link
Contributor

@jackleeio jackleeio commented May 16, 2024

Pre-flight checklist


This change is Reviewable

Copy link

vercel bot commented May 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
conflux-documentation ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 11, 2024 3:57pm

Copy link
Collaborator

@darwintree darwintree left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think current version needs refactoring. As previously discussed, this article mainly serve as a tutorial for how to register the token and enable core space erc20 token bridging to espace, which means, the internal implementation is not important and will interfere the article's readability. The contract imlementation illustration can be put into the planned article on CrossSpaceCall explanation

How to modify:

  1. (use the cofluxscan contract view) just focus on the operation with simple illustration. Then this article can be moved into the tutorial folder. Or
  2. directly providing js/python scripts on the operation.

The difference depends on the target audience

@jackleeio
Copy link
Contributor Author

Are there any other issues? @darwintree

@darwintree
Copy link
Collaborator

Are there any other issues? @darwintree

Apologies for the delay in reviewing the recent articles. Our current focus is on addressing issues related to the upcoming Conflux hard fork. We estimate that the most urgent tasks will be completed by the end of next week, though it could take longer. We appreciate your patience if we are unable to review the recent pull requests in the coming days.

Copy link
Collaborator

@darwintree darwintree left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This article is moved to the tutorial folder, and should be considered as a normal-user-oriented article.

  1. For most users, the step sing the Official Cross-Space Bridge is enough. It is recommended to place it to the first place.
  2. If the token bridging is not applicable (not registered before), then reader can then check the currrent step 1 and 2 to register token and create token mapping
  3. Recommeded to remove current step 4 and 5 as currently this is enough for users, for example, if he or she would like to add liquidity to swappi. However, it is still acceptable if you would like to add relating content, but current version is not appropriate. For developers, it is a more reliable and authentic way to show how to modify the parameter in https://github.com/Conflux-Chain/conflux-dapps to deploy a fork version of the frontend

@jackleeio
Copy link
Contributor Author

jackleeio commented Jun 11, 2024

Here we can add a tutorial to tell developers how to implement it

This tutorial is clearly intended for developers. It is not suitable for most ordinary users, as their needs are completely different from the topic of this article. It’s unlikely that non-developers will be issuing a token and crossing space to eSpace.

For your first point, I recommend creating a simpler tutorial based on the Step 3 extension, rather than changing the existing structure.

Regarding the third point, as I mentioned before, this is an issue developers will likely encounter when their project issues a token and needs to cross space to eSpace.

@darwintree darwintree merged commit 3ef3b44 into Conflux-Chain:main Jun 12, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants