-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Security Advice for Creating a Wallet #695
Add Security Advice for Creating a Wallet #695
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the general idea content is good. But current version is not good enough for blockchain beginners as too many details are not presented in this article although they seem to be common knowledge.
I suggest adding more details to the article
|
||
## 1. Understanding the Essence of Wallets | ||
|
||
A blockchain wallet is essentially a tool for managing your private keys. The private key is a randomly generated string of numbers, while the mnemonic phrase is a human-readable version of the private key. For example: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not accurate. Mnemonic is human-readable version of random seed and private key can be derived from it
|
||
## 2. Choosing the Right Wallet Type for Your Needs | ||
|
||
There are various wallet types, including: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suppose more introduction or relating articles should be added to this section. I would suppose the reader be a beginner of blockchain world and current version would make it hard for reader to understand
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should add "what this is" as well as "what it is used for"
- Verify the randomness of the generated mnemonic phrase (avoid patterns in word combinations) | ||
|
||
## 5. Adopt a Multi-Wallet Strategy to Spread Risk | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add details illustrating why this strategy is required
- Don't concentrate all assets in a single wallet | ||
- Use a low-value wallet to test new projects or unfamiliar DApps | ||
|
||
## 6. Understanding Emerging Keyless Wallet Technology |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
More details are needed here
@@ -0,0 +1,9 @@ | |||
{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be removed
@@ -0,0 +1,4 @@ | |||
--- |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be removed
Co-authored-by: darwintree <[email protected]>
Updated based on feedback |
|
||
## 2. Choosing the Right Wallet Type for Your Needs | ||
|
||
There are various wallet types, including: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should add "what this is" as well as "what it is used for"
|
||
A wallet doesn't actually store your cryptocurrencies. Instead, it stores the keys that prove your ownership of these assets on the blockchain. Here are the key components: | ||
|
||
1. **Random Seed**: This is a large, randomly generated number that serves as the foundation of your wallet. It's the most crucial piece of information. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does this mean?
Pre-flight checklist
This change is