Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ERC20Permit to gas optimization #730

Merged
merged 4 commits into from
Sep 13, 2024
Merged

Add ERC20Permit to gas optimization #730

merged 4 commits into from
Sep 13, 2024

Conversation

jackleeio
Copy link
Contributor

@jackleeio jackleeio commented Sep 9, 2024 •
edited by boqiu
Loading

Pre-flight checklist

This change is Reviewable

@vercel Vercel
Copy link

vercel bot commented Sep 9, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
conflux-documentation ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 11, 2024 3:56pm

darwintree
darwintree requested changes Sep 11, 2024
View reviewed changes
Copy link
Collaborator

@darwintree darwintree left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should provide example signing code (frontend or simple hardhat script) for readers to try the code

@darwintree darwintree merged commit ee5fd55 into Conflux-Chain:main Sep 13, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darwintree darwintree darwintree approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jackleeio @darwintree