Fix and add browser support for tokenize function #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The tokenize function uses `fs` to read Solidity.tokens on runtime. This doesn't work in the browser. With this change, the parse and tokenize functions can be used in the browser.
|
@GNSPS could you review this? |
|
Thank you so much @fvictorio! These were some crazy days! I'll be monitoring activity much closer from now on! 🙏 |
|
LGTM, merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes two changes:
Solidity.tokenswas read on runtime using thefsmodule. I added a babel plugin to inline it in the necessary module.(This PR does pretty much the same as federicobond#100, but the commits are different because they come from a different branch. I don't know if this might cause merge conflicts with upstream in the future.)