New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix to current class model #4

Open

RhinoLu wants to merge 2 commits into CreateJS:master from RhinoLu:RhinoLu-fix

RhinoLu commented Sep 10, 2015

No description provided.


          fix to current class model

82d8536

Member

lannymcnie commented Oct 9, 2015

This port is not quite complete.

The initialize method has been deprecated in favor of using the constructor
Properties should no longer be declared on the prototype, but rather initialized and document inside of the constructor.
The new extend/promote removes the need for the p.DisplayObject_function = p.function approach, so those should be removed.

I also recommend changing the .addEventListener usages in the demo to .on().

If you can address these changes, I will accept the PR. Thanks for updating this class, and sorry for the late response!


          fix to current class model

e3038dc

Please check again. If there still have any mistake, just tell me.
Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet