-
Notifications
You must be signed in to change notification settings - Fork 86
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#194 define Preprocessor #262
Open
himaanisrivatsava
wants to merge
57
commits into
CrossGL:main
Choose a base branch
from
himaanisrivatsava:preprocessor
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat: Add DirectX preprocessor for handling #define, #ifdef, #include, and related directives refactor: Integrate preprocessor into DirectX lexer refactor: Update DirectX backend init to include preprocessing pipeline test: Add tests for DirectX preprocessor functionality fix: Improve error handling for invalid directives in preprocessor
for more information, see https://pre-commit.ci
Fix: importing HLSLLexer from crossGL backend
…rosstl into preprocessor
for more information, see https://pre-commit.ci
fix: rewrote the preprocessor test using pytest instead of Unittest
…rosstl into preprocessor
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
…rosstl into preprocessor
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
…rosstl into preprocessor
for more information, see https://pre-commit.ci
…rosstl into preprocessor
for more information, see https://pre-commit.ci
…rosstl into preprocessor
for more information, see https://pre-commit.ci
…rosstl into preprocessor
for more information, see https://pre-commit.ci
…rosstl into preprocessor
for more information, see https://pre-commit.ci
Mocking os.path.exists: I added the @patch("os.path.exists", return_value=True) decorator to mock os.path.exists for all the test methods that deal with file inclusion. This ensures that file existence checks return True during tests. Raising ValueError for Undefined Macros: I updated the expand_macros method to raise a ValueError when undefined macros are encountered.
for more information, see https://pre-commit.ci
…rosstl into preprocessor
for more information, see https://pre-commit.ci
…rosstl into preprocessor
for more information, see https://pre-commit.ci
corrected all the errors in the test_preprocessor.py module
…rosstl into preprocessor
himaanisrivatsava
requested review from
NripeshN and
vaatsalya123
as code owners
January 13, 2025 17:30
for more information, see https://pre-commit.ci
…rosstl into preprocessor
for more information, see https://pre-commit.ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Related Issue
Changes
Shader Sample (Optional)
Testing
Checklist
feat: Add DirectX preprocessor for handling #define, #ifdef, #include, and related directives
refactor: Integrate preprocessor into DirectX lexer
refactor: Update DirectX backend init to include preprocessing pipeline
test: Add tests for DirectX preprocessor functionality
fix: Improve error handling for invalid directives in preprocessor