Assignment tokens #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nment_tokens update
… into assignment_tokens merging
… modulus and modulus to the translator frontend. closes CrossGL#48,CrossGL#50,CrossGL#51,CrossGL#52,CrossGL#53
for more information, see https://pre-commit.ci
… into assignment_tokens merging
|
Hi @Proxihox |
samthakur587
requested changes
Aug 23, 2024
There was a problem hiding this comment.
hii @Proxihox you only added the tests where is actual changes for the translator laxer . can you please add those also.
|
Hi @samthakur587 , I mentioned a sidenote at the end of my PR. Lines 48,49,50,55 and 56 of 'lexer.py' already have the code from my previous PR. I'll try to avoid such confusions from happening next time. |
samthakur587
approved these changes
Aug 24, 2024
There was a problem hiding this comment.
hii @Proxihox yeah only tests are needed the tokens are already there . your tests are generating correct tokens . thanks for adding the tests .
everything LGTM 🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Added Assignment and, assignment or, assignment xor, xor , assignemnt modulus and modulus to the translator frontend.
Also wrote a test function for the lexer for most of the operators and assignment operators.
Related Issue
closes #48
closes #50
closes #51
closes #52
closes #53
shader Sample
"""
int a = 1;
a += 1;
a *= 2;
a /= a;
a -= -1;
a %= 2;
a &= 1;
a |= 1;
a ^= 1;
"""
Side note: I must have mistakenly included the changes in 'translator/lexer.py' in my previous pull request so its not showing up as a change here.