Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored Logical Operation token in Translator Frontend #91

Merged

Conversation

ArchitGupta07
Copy link
Contributor

@ArchitGupta07 ArchitGupta07 commented Aug 22, 2024

PR Description

This PR introduces the following changes:

Tokens for Logical OR and Logical AND have been implemented in lexer.py.
A test has been added for Logical operators tokenization in test_lexer.py,

Related Issue

This PR attempts to solve the following issues:
Closes Issue #57
closes #56

Checklist

  • Have you added the necessary tests?
  • Only modified the files mentioned in the related issue(s)?
  • Are all tests passing?

@samthakur587
Copy link
Contributor

hii @ArchitGupta07 can you mention issue also here on which you are working on .

@ArchitGupta07
Copy link
Contributor Author

hii @ArchitGupta07 can you mention issue also here on which you are working on .

samthakur587 Updated the Desciption.

Copy link
Contributor

@samthakur587 samthakur587 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @ArchitGupta07 everything LGTM 🚀 great work

@NripeshN NripeshN merged commit 6173701 into CrossGL:main Aug 22, 2024
8 checks passed
rigved-desai pushed a commit to rigved-desai/crosstl that referenced this pull request Aug 23, 2024
* "Logical Operator Added in Translator frontend

* commit

* Logical operator added in translator frontend along with tests

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
@AxelB1011 AxelB1011 mentioned this pull request Aug 29, 2024
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Logical OR Token at translator frontend Add Logical AND Token at translator frontend
3 participants