-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add functionality to retrieve, and use pre-generated auth token for authentication for bash scripts. #284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gtheodorio
changed the title
Add functionality to retrieve, and use pre-generated auth token for authentication.
Add functionality to retrieve, and use pre-generated auth token for authentication for bash scripts.
Apr 23, 2024
carlosmmatos
force-pushed
the
bash_auth_token
branch
from
May 1, 2024 16:40
bec22a7
to
1a11352
Compare
carlosmmatos
reviewed
May 1, 2024
carlosmmatos
reviewed
May 1, 2024
This commit includes a lot of missing functionality and adds a couple of enhancements that were much needed. The help menu has also been updated to be more verbose.
carlosmmatos
force-pushed
the
bash_auth_token
branch
from
June 4, 2024 13:30
3b3cc3c
to
1fd2fc0
Compare
This takes some of the logic implemented in the uninstall script to deal with ensuring that no api calls are made if a user passes in an option like -h to the script. By wrapping those calls in funcs and only calling them when appropriate, the script will run accordingly.
carlosmmatos
approved these changes
Jun 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gtheodorio double check my updates, but I think these changes are good to go.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add functionality to retrieve, and use pre-generated auth token for authentication for bash scripts.
#211