Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(bash install): add api retrieval for provisioning token #359

Merged
merged 4 commits into from
Aug 19, 2024

Conversation

carlosmmatos
Copy link
Contributor

Fixes #354

This PR introduces the ability to retrieve your provisioning token from the API, the same we can retrieve the CID. Per security reasons, it may not be logical to expose your installation tokens in plain-text, so this way can do it "behind" the scene.

The way this works is (assuming you do not pass in a provisioning-token):

  1. We check your existing token settings
  2. If installation tokens are required in your CID:
    1. We grab a token ID
    2. We grab the value from the token ID
  3. We set that as the provisioning-token

So we only do something if tokens are required, which is the key here.

Fixes CrowdStrike#354

This PR introduces the ability to retrieve your provisioning token from
the API, the same we can retrieve the CID. Per security reasons, it may
not be logical to expose your installation tokens in plain-text, so this
way can do it "behind" the scene.
@carlosmmatos carlosmmatos added enhancement New feature or request bash linux next release Issues targeted for next release labels Aug 17, 2024
@carlosmmatos carlosmmatos added this to the 1.6.0 milestone Aug 17, 2024
@carlosmmatos carlosmmatos self-assigned this Aug 17, 2024
@carlosmmatos carlosmmatos merged commit 896c6b8 into CrowdStrike:main Aug 19, 2024
4 checks passed
@carlosmmatos carlosmmatos deleted the carlosmmatos/issue354 branch August 19, 2024 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bash enhancement New feature or request linux next release Issues targeted for next release ok-to-test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

(bash) add ability to retrieve installation token via API
2 participants