Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update login with email when changed. #51

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jcwatson11
Copy link
Contributor

@jcwatson11 jcwatson11 commented Aug 1, 2024

Hi @Omicron7,

Just a quick sanity check here. We decided to go ahead and promote this code to stage thinking that it likely won't break anything in any case, and if it doesn't properly set the login value when we upgrade Okta in Stage, then we can scratch our heads and come up with something new at that point. But it's worth a try.

If all of that sounds reasonable and you don't believe this code change will introduce risk, please approve.

Thanks!

Copy link

I see you added the "On Staging" label, I'll get this merged to the staging branch!

@Omicron7
Copy link
Contributor

Omicron7 commented Aug 2, 2024

@jcwatson11 You don't need approval to test things in stage. I've triggered stage release with On Staging label. I'm going to approve this, but don't merge to master until we know it's working.

@jcwatson11
Copy link
Contributor Author

Hi @Omicron7,

Thank you for your kind reminder that we don't need approval to test things in stage. I do understand that. I was more interested in a sanity check related to our reasoning and planning related to this particular change. It's okay. We can test in stage and see if it breaks anything.

Thanks again for your brain dump! I appreciate you, Brian!

Jon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants