Fix some typos (most of them found by codespell) #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stweil
commented
Jun 13, 2022
| @@ -36,7 +36,7 @@ def parse_arguments(): | |||
| parser.add_argument('--output-logit-path', help='') | |||
| parser.add_argument('--output-alto-path', help='') | |||
| parser.add_argument('--output-transcriptions-file-path', help='') | |||
| parser.add_argument('--skipp-missing-xml', action='store_true', help='Skipp images which have missing xml.') | |||
| parser.add_argument('--skipp-missing-xml', action='store_true', help='Skip images which have missing xml.') | |||
There was a problem hiding this comment.
I suggest to replace the argument by --skip-missing-xml, too, but that might break existing documentation or applications and needs a fix for line 301, too. There is already an argument --skip-processed, so fixing the one here would also make the arguments more consistent.
stweil
commented
Jun 13, 2022
| @@ -36,7 +36,7 @@ def parse_arguments(): | |||
| parser.add_argument('--output-logit-path', help='') | |||
| parser.add_argument('--output-alto-path', help='') | |||
| parser.add_argument('--output-transcriptions-file-path', help='') | |||
| parser.add_argument('--skipp-missing-xml', action='store_true', help='Skipp images which have missing xml.') | |||
| parser.add_argument('--skipp-missing-xml', action='store_true', help='Skip images which have missing xml.') | |||
There was a problem hiding this comment.
Suggested change
| parser.add_argument('--skipp-missing-xml', action='store_true', help='Skip images which have missing xml.') | |
| parser.add_argument('--skip-missing-xml', action='store_true', help='Skip images which have missing xml.') |
There was a problem hiding this comment.
Should I add this change to the pull request?
stweil
commented
Jun 13, 2022
user_scripts/parse_folder.py
Outdated
| @@ -36,7 +36,7 @@ def parse_arguments(): | |||
| parser.add_argument('--output-logit-path', help='') | |||
| parser.add_argument('--output-alto-path', help='') | |||
| parser.add_argument('--output-transcriptions-file-path', help='') | |||
| parser.add_argument('--skipp-missing-xml', action='store_true', help='Skipp images which have missing xml.') | |||
| parser.add_argument('--skipp-missing-xml', action='store_true', help='Skip images which have missing xml.') | |||
| parser.add_argument('--set-gpu', action='store_true', help='Sets visible CUDA device to first unused GPU.') | |||
| parser.add_argument('--process-count', type=int, default=1, help='Number of parallel processes (this works mostly only for line cropping and it probably fails and crashes for most other uses cases).') | |||
There was a problem hiding this comment.
Suggested change
| parser.add_argument('--process-count', type=int, default=1, help='Number of parallel processes (this works mostly only for line cropping and it probably fails and crashes for most other uses cases).') | |
| parser.add_argument('--process-count', type=int, default=1, help='Number of parallel processes (this works mostly only for line cropping and it probably fails and crashes for most other use cases).') |
|
There was a new typo in README, so I pushed another commit. |
Signed-off-by: Stefan Weil <[email protected]>
Signed-off-by: Stefan Weil <[email protected]>
Signed-off-by: Stefan Weil <[email protected]>
Signed-off-by: Stefan Weil <[email protected]>
Signed-off-by: Stefan Weil <[email protected]>
|
Added another fix, rebased and fixed merge conflicts now. Please consider merging this pull request. |
Signed-off-by: Stefan Weil <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Stefan Weil [email protected]