Merge pull request #10241 from DFE-Digital/545-part-2-remove-feature-…

…flag-from-database

[545] part 2 remove feature flag from database

app/services/data_migrations/remove_new_withdrawal_reasons_feature_flag.rb

@@ -0,0 +1,10 @@
+module DataMigrations
+  class RemoveNewWithdrawalReasonsFeatureFlag
+    TIMESTAMP = 20250109170301
+    MANUAL_RUN = false
+
+    def change
+      Feature.where(name: :new_candidate_withdrawal_reasons).delete_all
+    end
+  end
+end

lib/tasks/data.rake

@@ -1,5 +1,6 @@
 DATA_MIGRATION_SERVICES = [
   # do not delete or edit this line - services added below by generator
+  'DataMigrations::RemoveNewWithdrawalReasonsFeatureFlag',
   'DataMigrations::RemoveUnusedFeatureFlags',
   'DataMigrations::RemoveTdaFlag',
   'DataMigrations::DeleteAllOldAudits',

spec/services/data_migrations/remove_new_withdrawal_reasons_feature_flag_spec.rb

@@ -0,0 +1,20 @@
+require 'rails_helper'
+
+RSpec.describe DataMigrations::RemoveNewWithdrawalReasonsFeatureFlag do
+  context 'when the feature flag exist' do
+    it 'removes the relevant feature flags' do
+      create(:feature, name: 'new_candidate_withdrawal_reasons')
+      create(:feature, name: 'some_other_feature_flag')
+
+      expect { described_class.new.change }.to change { Feature.count }.by(-1)
+      expect(Feature.where(name: 'new_candidate_withdrawal_reasons')).to be_none
+      expect(Feature.where(name: 'some_other_feature_flag')).to be_any
+    end
+  end
+
+  context 'when the feature flags have already been dropped' do
+    it 'does nothing' do
+      expect { described_class.new.change }.not_to(change { Feature.count })
+    end
+  end
+end