-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[558] Add email to candidates about login changes DO NOT MERGE #10259
Open
elceebee
wants to merge
1
commit into
main
Choose a base branch
from
558-one-login-draft-and-schedule-email-to-candidates-pre-release
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[558] Add email to candidates about login changes DO NOT MERGE #10259
elceebee
wants to merge
1
commit into
main
from
558-one-login-draft-and-schedule-email-to-candidates-pre-release
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elceebee
force-pushed
the
558-one-login-draft-and-schedule-email-to-candidates-pre-release
branch
from
January 14, 2025 14:44
bfc5a98
to
0efeafe
Compare
elceebee
force-pushed
the
558-one-login-draft-and-schedule-email-to-candidates-pre-release
branch
from
January 14, 2025 17:34
0efeafe
to
e66c112
Compare
elceebee
force-pushed
the
558-one-login-draft-and-schedule-email-to-candidates-pre-release
branch
from
January 15, 2025 08:49
e66c112
to
19c999c
Compare
avinhurry
approved these changes
Jan 15, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a tiny comment. Looks good
dcyoung-dev
approved these changes
Jan 16, 2025
elceebee
force-pushed
the
558-one-login-draft-and-schedule-email-to-candidates-pre-release
branch
from
January 16, 2025 11:20
19c999c
to
a02881d
Compare
elceebee
force-pushed
the
558-one-login-draft-and-schedule-email-to-candidates-pre-release
branch
from
January 16, 2025 14:04
a02881d
to
f82d313
Compare
elceebee
changed the title
Add email to candidates about login changes
[558] Add email to candidates about login changes DO NOT MERGE
Jan 16, 2025
elceebee
force-pushed
the
558-one-login-draft-and-schedule-email-to-candidates-pre-release
branch
from
January 17, 2025 13:01
45e6ccb
to
4807744
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
We wish to email candidates in the imminent week(s) that the way they login to our service is changing.
Recognising that lots of new candidates sign up each day, we will send this email daily to new sign ups until the feature flag is activated.
Once the feature flag is activated and things are working normally, we will delete this email and worker from the code base as it's not to be reused. Even if we deactivate the feature flag, it won't really make much sense...
The first email that is sent will go to about 53k candidates. Subsequent messages sent daily will just be sent to candidates who have signed that day.
The message will not be sent to anyone whose account is locked, submission blocked, or unsubscribed.
Changes proposed in this pull request
Worker and email and associated tests.
Guidance to review
rails/mailers/candidate_mailer/one_login_is_coming
Link to Trello card
https://trello.com/c/ZAtlIyJO
Things to check