Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[558] Add email to candidates about login changes DO NOT MERGE #10259

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

elceebee
Copy link
Contributor

@elceebee elceebee commented Jan 14, 2025

Context

We wish to email candidates in the imminent week(s) that the way they login to our service is changing.

Recognising that lots of new candidates sign up each day, we will send this email daily to new sign ups until the feature flag is activated.

Once the feature flag is activated and things are working normally, we will delete this email and worker from the code base as it's not to be reused. Even if we deactivate the feature flag, it won't really make much sense...

The first email that is sent will go to about 53k candidates. Subsequent messages sent daily will just be sent to candidates who have signed that day.

The message will not be sent to anyone whose account is locked, submission blocked, or unsubscribed.

Changes proposed in this pull request

Worker and email and associated tests.

Guidance to review

  • Does the query look correct?
  • The email can be previewed locally or on the review app at rails/mailers/candidate_mailer/one_login_is_coming

Link to Trello card

https://trello.com/c/ZAtlIyJO

Things to check

  • If the code removes any existing feature flags, a data migration has also been added to delete the entry from the database
  • This code does not rely on migrations in the same Pull Request
  • If this code includes a migration adding or changing columns, it also backfills existing records for consistency
  • If this code adds a column to the DB, decide whether it needs to be in analytics yml file or analytics blocklist, if included inform data insights team of the changes
  • If this code adds a column that may include PII, the sanitise.sql script and 0025-protecting-personal-data-in-production-dump.md ADR have been updated.
  • API release notes have been updated if necessary
  • If it adds a significant user-facing change, is it documented in the CHANGELOG?
  • Attach the PR to the Trello card

@elceebee elceebee added the deploy_v2 Deploy the review app to AKS label Jan 14, 2025
@elceebee elceebee self-assigned this Jan 14, 2025
@github-actions github-actions bot temporarily deployed to review_aks-10259 January 14, 2025 14:31 Destroyed
@elceebee elceebee force-pushed the 558-one-login-draft-and-schedule-email-to-candidates-pre-release branch from bfc5a98 to 0efeafe Compare January 14, 2025 14:44
@github-actions github-actions bot temporarily deployed to review_aks-10259 January 14, 2025 14:51 Destroyed
@elceebee elceebee marked this pull request as ready for review January 14, 2025 15:53
@elceebee elceebee requested a review from a team January 14, 2025 15:54
@elceebee elceebee force-pushed the 558-one-login-draft-and-schedule-email-to-candidates-pre-release branch from 0efeafe to e66c112 Compare January 14, 2025 17:34
@github-actions github-actions bot temporarily deployed to review_aks-10259 January 14, 2025 17:39 Destroyed
@elceebee elceebee force-pushed the 558-one-login-draft-and-schedule-email-to-candidates-pre-release branch from e66c112 to 19c999c Compare January 15, 2025 08:49
@github-actions github-actions bot temporarily deployed to review_aks-10259 January 15, 2025 08:54 Destroyed
Copy link
Contributor

@CatalinVoineag CatalinVoineag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a tiny comment. Looks good

@elceebee elceebee force-pushed the 558-one-login-draft-and-schedule-email-to-candidates-pre-release branch from 19c999c to a02881d Compare January 16, 2025 11:20
@github-actions github-actions bot temporarily deployed to review_aks-10259 January 16, 2025 11:30 Destroyed
@elceebee elceebee force-pushed the 558-one-login-draft-and-schedule-email-to-candidates-pre-release branch from a02881d to f82d313 Compare January 16, 2025 14:04
@github-actions github-actions bot temporarily deployed to review_aks-10259 January 16, 2025 14:09 Destroyed
@elceebee elceebee changed the title Add email to candidates about login changes [558] Add email to candidates about login changes DO NOT MERGE Jan 16, 2025
@github-actions github-actions bot temporarily deployed to review_aks-10259 January 17, 2025 11:06 Destroyed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deploy_v2 Deploy the review app to AKS DO NOT MERGE
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants