Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[560 & 562] One login pre-release banners #10272

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

elceebee
Copy link
Contributor

@elceebee elceebee commented Jan 16, 2025

Context

This PR is for two related tickets:
560: A banner displayed to logged in candidates on the personal details and application choices tab to let them know one login is coming
562: A banner displayed on the sign in pages to let candidate users know that one login is coming.

We will put this behind a feature flag -- it will only be displayed when the feature flag is active AND one login is is deactivated.

Changes proposed in this pull request

  • Two banner components and related specs and previews
  • Changes to the relevant views to display the banners
  • Feature flag for toggling banners on / off.
Sign-in page Details page
image image

Guidance to review

Locally and in the review app, check to see if the banners are displayed as expected. Note that the banner will not display when logged in unless the flash content is empty.

Things to check

  • If the code removes any existing feature flags, a data migration has also been added to delete the entry from the database
  • This code does not rely on migrations in the same Pull Request
  • If this code includes a migration adding or changing columns, it also backfills existing records for consistency
  • If this code adds a column to the DB, decide whether it needs to be in analytics yml file or analytics blocklist, if included inform data insights team of the changes
  • If this code adds a column that may include PII, the sanitise.sql script and 0025-protecting-personal-data-in-production-dump.md ADR have been updated.
  • API release notes have been updated if necessary
  • If it adds a significant user-facing change, is it documented in the CHANGELOG?
  • Attach the PR to the Trello card

@elceebee elceebee added the deploy_v2 Deploy the review app to AKS label Jan 16, 2025
@elceebee elceebee self-assigned this Jan 16, 2025
@github-actions github-actions bot temporarily deployed to review_aks-10272 January 16, 2025 17:53 Destroyed
@elceebee
Copy link
Contributor Author

@elceebee
Copy link
Contributor Author

@github-actions github-actions bot temporarily deployed to review_aks-10272 January 16, 2025 18:09 Destroyed
@elceebee elceebee force-pushed the 562-one-login-create-service-banner-for-sign-in-page-pre-release branch from 5d97b75 to 0118607 Compare January 17, 2025 09:15
@github-actions github-actions bot temporarily deployed to review_aks-10272 January 17, 2025 09:20 Destroyed
@elceebee elceebee force-pushed the 562-one-login-create-service-banner-for-sign-in-page-pre-release branch from 0118607 to 41fce76 Compare January 17, 2025 09:30
@github-actions github-actions bot temporarily deployed to review_aks-10272 January 17, 2025 09:35 Destroyed
@elceebee elceebee marked this pull request as ready for review January 17, 2025 09:36
@elceebee elceebee requested a review from a team January 17, 2025 09:36
Copy link
Contributor

@CatalinVoineag CatalinVoineag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice 👍🏻

@github-actions github-actions bot temporarily deployed to review_aks-10272 January 17, 2025 09:47 Destroyed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deploy_v2 Deploy the review app to AKS DO NOT MERGE
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants