-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[560 & 562] One login pre-release banners #10272
Open
elceebee
wants to merge
4
commits into
main
Choose a base branch
from
562-one-login-create-service-banner-for-sign-in-page-pre-release
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[560 & 562] One login pre-release banners #10272
elceebee
wants to merge
4
commits into
main
from
562-one-login-create-service-banner-for-sign-in-page-pre-release
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elceebee
force-pushed
the
562-one-login-create-service-banner-for-sign-in-page-pre-release
branch
from
January 17, 2025 09:15
5d97b75
to
0118607
Compare
elceebee
force-pushed
the
562-one-login-create-service-banner-for-sign-in-page-pre-release
branch
from
January 17, 2025 09:30
0118607
to
41fce76
Compare
CatalinVoineag
approved these changes
Jan 17, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice 👍🏻
dcyoung-dev
approved these changes
Jan 17, 2025
elceebee
force-pushed
the
562-one-login-create-service-banner-for-sign-in-page-pre-release
branch
from
January 17, 2025 11:05
41fce76
to
27146f9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
This PR is for two related tickets:
560: A banner displayed to logged in candidates on the personal details and application choices tab to let them know one login is coming
562: A banner displayed on the sign in pages to let candidate users know that one login is coming.
We will put this behind a feature flag -- it will only be displayed when the feature flag is active AND one login is is deactivated.
Changes proposed in this pull request
Guidance to review
Locally and in the review app, check to see if the banners are displayed as expected. Note that the banner will not display when logged in unless the flash content is empty.
Things to check