Ensure evidence file names don't exceed limit (#770)

DFE-Digital · Dec 1, 2023 · 8d7b16d · 8d7b16d
1 parent 457c0c8
commit 8d7b16d
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 2 deletions.
diff --git a/...server/src/TeacherIdentity.AuthServer/Pages/Account/OfficialDateOfBirth/Confirm.cshtml.cs b/...server/src/TeacherIdentity.AuthServer/Pages/Account/OfficialDateOfBirth/Confirm.cshtml.cs
@@ -48,7 +48,7 @@ public async Task<IActionResult> OnPost()
         var teacherDobChangeRequest = new TeacherDateOfBirthChangeRequest()
         {
             DateOfBirth = DateOfBirth!.Value,
-            EvidenceFileName = FileName!,
+            EvidenceFileName = FileName!.Truncate(DqtApiClient.MaxEvidenceFileNameLength),
             EvidenceFileUrl = sasUri,
             Trn = User.GetTrn()!
         };

diff --git a/...et-authserver/src/TeacherIdentity.AuthServer/Pages/Account/OfficialName/Confirm.cshtml.cs b/...et-authserver/src/TeacherIdentity.AuthServer/Pages/Account/OfficialName/Confirm.cshtml.cs
@@ -68,7 +68,7 @@ public async Task<IActionResult> OnPost()
             FirstName = FirstName!,
             MiddleName = MiddleName,
             LastName = LastName!,
-            EvidenceFileName = FileName!,
+            EvidenceFileName = FileName!.Truncate(DqtApiClient.MaxEvidenceFileNameLength),
             EvidenceFileUrl = sasUri,
             Trn = User.GetTrn()!
         };

diff --git a/dotnet-authserver/src/TeacherIdentity.AuthServer/Services/DqtApi/DqtApiClient.cs b/dotnet-authserver/src/TeacherIdentity.AuthServer/Services/DqtApi/DqtApiClient.cs
@@ -7,6 +7,8 @@ namespace TeacherIdentity.AuthServer.Services.DqtApi;
 
 public class DqtApiClient : IDqtApiClient
 {
+    public const int MaxEvidenceFileNameLength = 100;
+
     private readonly HttpClient _client;
 
     private static JsonSerializerOptions _serializerOptions { get; } = new JsonSerializerOptions(JsonSerializerDefaults.Web)

diff --git a/dotnet-authserver/src/TeacherIdentity.AuthServer/StringExtensions.cs b/dotnet-authserver/src/TeacherIdentity.AuthServer/StringExtensions.cs
@@ -3,4 +3,6 @@ namespace TeacherIdentity.AuthServer;
 public static class StringExtensions
 {
     public static string? ToNullIfEmpty(this string? value) => string.IsNullOrWhiteSpace(value) ? null : value;
+
+    public static string Truncate(this string value, int maxLength) => value.Length > maxLength ? value[..maxLength] : value;
 }