Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add smaller zoom increments #133

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Add smaller zoom increments #133

wants to merge 1 commit into from

Conversation

realSquidCoder
Copy link
Contributor

Addresses #89

@realSquidCoder realSquidCoder marked this pull request as ready for review January 13, 2025 17:45
myk002
myk002 reviewed Jan 14, 2025
View reviewed changes
Copy link
Member

@myk002 myk002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

from testing, this new algorithm zooms in more smoothly, but does not gracefully handle zooming out.

How about just changing the base of the exponential from 2.0f to 1.1f? In my testing, that appears to give good, consistent granularity.

Also, please add a changelog entry for this improvement.

@myk002
Copy link
Member

myk002 commented Jan 14, 2025 •
edited
Loading

"Addresses" isn't a recognized keyword. Could you change the PR description to:

Fixes: #89

?

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@myk002 myk002 myk002 left review comments

Assignees
No one assigned
Labels
None yet
Projects
50.15-r2
Status: Todo
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@realSquidCoder @myk002