Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/exclude submit from final validation #859

Merged
merged 4 commits into from
Jan 15, 2025

Conversation

EdoStorm96
Copy link
Contributor

Ok so, hear me out. To me this is a nice fix for removing the submit from the 'all errors' display on the submit page. It can also be reused in the submit form.

I know you did not want this, but consider it :)

@EdoStorm96 EdoStorm96 requested a review from miggol January 15, 2025 12:08
Copy link
Contributor

@miggol miggol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know you did not want this, but consider it :)

Well I think your judgement has rightly prevailed here. Can't argue with the fact that it just works and works well.

@EdoStorm96 EdoStorm96 merged commit f2ce467 into develop Jan 15, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants