-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(pyproject): add N
(pep8 naming) rule to ruff config...
#334
Conversation
8f0add5
to
f0a7ef4
Compare
snake_case ...? |
a91be64
to
f006bb0
Compare
|
a7524c8
to
bc4ac8a
Compare
Alright, I converted the attributes to snake_case and the column name in PascalCase. |
I guess this error is expected: https://github.com/DIRACGrid/diracx/actions/runs/12135284425/job/33834028304?pr=334#step:14:205 Because I modified the DB schema of |
bc4ac8a
to
b17c67d
Compare
0d8b225
to
782cfee
Compare
f794af9
to
c9e848d
Compare
a3037f2
to
34d1398
Compare
a2b4366
to
bd7c7d0
Compare
79f9693
to
7f6f884
Compare
for more information, see https://pre-commit.ci
...Before it becomes too inconsistent.
Partially solves #34
It seems there is no clear choice for the attributes of the SQL Alchemy classes and we actually write them in 2 different ways:
snake case (this is how it is presented in the SQLAlchemy documentation):
diracx/diracx-db/src/diracx/db/sql/auth/schema.py
Lines 40 to 48 in 34095d8
camel case:
diracx/diracx-db/src/diracx/db/sql/job/schema.py
Lines 65 to 70 in 34095d8
We should probably make an opinionated choice and specify it in
CODING_CONVENTION.md
.Any opinion?
Needs: DIRACGrid/DIRAC#7968