Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Requests → httpx #374

Merged
merged 10 commits into from
Jan 17, 2025
Merged

Requests → httpx #374

merged 10 commits into from
Jan 17, 2025

Conversation

maxnoe
Copy link
Contributor

@maxnoe maxnoe commented Jan 15, 2025 •
edited
Loading

Notes for reviewers:

  • The get_openid_config seems to be not covered by tests, see 55522d5
  • requests was imported in the patch file for the autogenerated client code, but marked as not used. See 7de3db1
  • The async client uses the sync get_openid_config, should probably be using its own async version

Fixes #338

@chaen chaen closed this Jan 16, 2025
@chaen chaen reopened this Jan 16, 2025
@maxnoe maxnoe force-pushed the remove_requests branch 3 times, most recently from e9cc268 to 0b85ed3 Compare January 16, 2025 11:03
@chaen chaen enabled auto-merge January 17, 2025 15:54
@chaen chaen merged commit 8d410ad into DIRACGrid:main Jan 17, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chaen chaen chaen approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use httpx instead of requests
2 participants
@maxnoe @chaen