Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/map reset #172

Closed
wants to merge 19 commits into from
Closed

Feature/map reset #172

wants to merge 19 commits into from

Conversation

Pawandeep-Kaur-Betz
Copy link
Collaborator

@Pawandeep-Kaur-Betz Pawandeep-Kaur-Betz commented Sep 14, 2022

For issue #98 and #92

  1. Reset the values to Germany: A reset icon is added at the search bar
  2. Reset zoom level. A home icon is added to the map that resets the zoom level to the default. It also changes the value to Germany wide. Till the time highlight district is not activated on the map, this functionality is needed else, its difficult to track the selected district on the map view.

https://gist.github.com/NXXR/5f71f73b3259769a336728629017d600

@github-actions
Copy link

github-actions bot commented Sep 14, 2022

Unit Test Results

  1 files  ±0  12 suites  ±0   21s ⏱️ -1s
30 tests ±0  30 ✔️ ±0  0 💤 ±0  0 ±0 
31 runs  ±0  31 ✔️ ±0  0 💤 ±0  0 ±0 

Results for commit 1c0303c. ± Comparison against base commit 72bd4e1.

♻️ This comment has been updated with latest results.

@coveralls
Copy link

coveralls commented Sep 14, 2022

Pull Request Test Coverage Report for Build 3714935445

  • 1 of 8 (12.5%) changed or added relevant lines in 3 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.1%) to 20.014%

Changes Missing Coverage Covered Lines Changed/Added Lines %
frontend/src/components/Sidebar/SearchBar.tsx 1 2 50.0%
frontend/src/components/Sidebar/DistrictMap.tsx 0 2 0.0%
frontend/src/util/customIcons.tsx 0 4 0.0%
Files with Coverage Reduction New Missed Lines %
frontend/src/components/Sidebar/DistrictMap.tsx 1 0%
Totals Coverage Status
Change from base Build 3629306565: -0.1%
Covered Lines: 232
Relevant Lines: 920

💛 - Coveralls

@JonasGilg JonasGilg requested a review from NXXR September 16, 2022 12:08
Copy link
Collaborator

@NXXR NXXR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some changes from other PRs mixed in again.
Also, the zoom out button also selects germany again, I'm confused on what we decided on for the interaction.

if you merge PR #149 and pull the develop branch these changes might resolve themselves.

frontend/src/components/ScenarioCard.tsx Outdated Show resolved Hide resolved
frontend/src/components/ScenarioCard.tsx Outdated Show resolved Hide resolved
frontend/src/components/ScenarioCard.tsx Outdated Show resolved Hide resolved
frontend/src/components/Sidebar/DistrictMap.tsx Outdated Show resolved Hide resolved
frontend/src/components/Sidebar/DistrictMap.tsx Outdated Show resolved Hide resolved
frontend/src/components/Sidebar/DistrictMap.tsx Outdated Show resolved Hide resolved
Copy link
Collaborator

@NXXR NXXR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The size of the gemany icon/button does not match the size of the other two buttons.
or is that just with my build?

Also make sure to pull the newest changes of the develop branch and resolve any issues blocking the merge :)

@NXXR NXXR assigned Pawandeep-Kaur-Betz and unassigned NXXR Oct 25, 2022
@NXXR NXXR self-assigned this Oct 28, 2022
@Pawandeep-Kaur-Betz
Copy link
Collaborator Author

The size of the gemany icon/button does not match the size of the other two buttons. or is that just with my build?

I am not sure how it looks at your end, but at my side, it does not look much bigger or different.

@Pawandeep-Kaur-Betz
Copy link
Collaborator Author

Also make sure to pull the newest changes of the develop branch and resolve any issues blocking the merge :)
Done

@Pawandeep-Kaur-Betz Pawandeep-Kaur-Betz removed their assignment Dec 16, 2022
@NXXR
Copy link
Collaborator

NXXR commented Jan 30, 2023

The size of the gemany icon/button does not match the size of the other two buttons. or is that just with my build?

I am not sure how it looks at your end, but at my side, it does not look much bigger or different.

grafik

This is how it looks on my end.
I was talking with Jonas to check if it was a problem on my end.

I think we should try to get the button into the map controls container so it's closer and in the same style as the zoom buttons.

This way it doesn't look out of place between the zoom controls and the heat legend buttons.

If we can't get it into the zoom controls we should try to at least match the style.

Copy link
Collaborator

@NXXR NXXR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

see comment above.

@NXXR NXXR removed their assignment Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Button to go back to values for Germany (total) Reset/recenter district map when zooming back out
3 participants