-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/map reset #172
Feature/map reset #172
Conversation
Pull Request Test Coverage Report for Build 3714935445
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some changes from other PRs mixed in again.
Also, the zoom out button also selects germany again, I'm confused on what we decided on for the interaction.
if you merge PR #149 and pull the develop branch these changes might resolve themselves.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The size of the gemany icon/button does not match the size of the other two buttons.
or is that just with my build?
Also make sure to pull the newest changes of the develop branch and resolve any issues blocking the merge :)
I am not sure how it looks at your end, but at my side, it does not look much bigger or different. |
|
This is how it looks on my end. I think we should try to get the button into the map controls container so it's closer and in the same style as the zoom buttons. This way it doesn't look out of place between the zoom controls and the heat legend buttons. If we can't get it into the zoom controls we should try to at least match the style. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
see comment above.
For issue #98 and #92
https://gist.github.com/NXXR/5f71f73b3259769a336728629017d600