Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix invalid start date cache #317

Merged
merged 3 commits into from
Nov 9, 2023

Conversation

JonasGilg
Copy link
Collaborator

@JonasGilg JonasGilg commented Nov 9, 2023

Description

Fixed a bug, that crashed the website, because of a cached start date.

Checklist

I, the author of this PR checked the following requirements for good software quality:

  • The code is properly formatted (I ran the formatter)
  • The code is written with our software quality standards (I ran the linter)
  • The code is written using our code style
  • Extensive in source documentation has been added
  • Unit and/or integration tests have been added
  • All texts have been internationalized with at least the following languages:
    • English
    • German
  • I tried addressing all new accessibility problems displayed in the console and documented if they can't be fixed
  • I attached performance measurements to prevent performance degradation
  • I added the changes to the next release section of the changelog

I, the reviewer checked the following things:

  • I ran the software once and tried all new and related functionality to this PR
  • I looked at all new and changed lines of code and commented on possible problems
  • I read the added documentation and checked if it is understandable and clear
  • I checked the added tests for completeness
  • I checked the internationalized strings for spelling errors
  • I checked the performance metrics for problems or unexplained degradation
  • I checked that the changes are noted in the changelog

@JonasGilg JonasGilg added class:bug Something isn't working type:web-frontend labels Nov 9, 2023
@JonasGilg JonasGilg requested a review from NXXR November 9, 2023 10:23
@JonasGilg JonasGilg self-assigned this Nov 9, 2023
Copy link

github-actions bot commented Nov 9, 2023

Unit Test Results

  1 files  ±0  14 suites  ±0   49s ⏱️ +24s
32 tests ±0  32 ✔️ ±0  0 💤 ±0  0 ±0 
33 runs  ±0  33 ✔️ ±0  0 💤 ±0  0 ±0 

Results for commit 7c5dfc8. ± Comparison against base commit b4af3c5.

♻️ This comment has been updated with latest results.

@JonasGilg JonasGilg merged commit 5a49523 into develop Nov 9, 2023
5 checks passed
@JonasGilg JonasGilg deleted the feature/fix-invalid-start-date-cache branch November 9, 2023 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
class:bug Something isn't working type:web-frontend
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants