-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated namespace with keyInfo item; added 'anyOption' to records #383
Updated namespace with keyInfo item; added 'anyOption' to records #383
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
the Prettier Job failed
check if running npm run format
makes things better or worse.
If worse you can either remove the leading comments in the maps since I assume they are the reason why the formatter is unhappy. Otherwise, you can probably also exclude this file from the formatter somehow.
I also checked the differences between Other than that the only major change is that the raw data is served as an array not a crossfilter anymore, and therefore an additional large crossfilter object with the agent and location infos merged into the trips is provided for @Pawandeep-Kaur-Betz statistics and @apoorvakay might also use this object to filter and display the map (if she doesn't use the raw trip and location array and filter based on the You can check the datasocket code if there are any comments or todos that need fixing but I think most of it was optional for now. |
Co-authored-by: Moritz Zeumer <[email protected]>
Did you find the issue with the formatter @hudaif747 ? |
The formatter fixed single qoutes in the pandemos.ts it did not mess with the rest of the file. The lint fix suggested to add disable comment for namespace and also to remove non-null assertions in the PandemosContext.tsx |
c99eea5
into
feature/pandemos-datasocket-preprocessing
Description
Related Issues
Design Decisions
Performance & Quality
Checklist
I, the author of this PR checked the following requirements for good software quality:
I, the reviewer checked the following things: