Merge pull request #984 from DLR-SC/962-bug-hard-crash-with-no-guidec…

…urves

Fix for hard crash if guiceCurves node is present but empty in wing segment

src/guide_curves/CCPACSGuideCurves.cpp

@@ -97,6 +97,13 @@ bool CCPACSGuideCurves::GuideCurveExists(std::string uid) const
 std::vector<double> CCPACSGuideCurves::GetRelativeCircumferenceParameters() const
 {
     std::vector<double> relCircs;
+
+    // CPACS 3.3 requires guideCurves to be present. To prevent a hard crash if this is NOT the case,
+    // we shoud exit here (or at least before the call to relCircs.back())
+    if (GetGuideCurveCount() == 0) {
+        return relCircs;
+    }
+
     for (int iguide = 1; iguide <=  GetGuideCurveCount(); ++iguide) {
         const CCPACSGuideCurve* root = GetGuideCurve(iguide).GetRootCurve();
         relCircs.push_back(*root->GetFromRelativeCircumference_choice2());

tests/unittests/tiglWingGuideCurves.cpp

@@ -499,3 +499,30 @@ TEST_F(WingGuideCurve, bug975)
     }
 
 }
+
+
+TEST_F(WingGuideCurve, bug962)
+{
+    //https://github.com/DLR-SC/tigl/issues/962
+
+    TixiDocumentHandle           tixi_h;
+    TiglCPACSConfigurationHandle tigl_h;
+
+    // open simpletest with tixi and add empty guidecurves node
+    const char* filename = "TestData/simpletest.cpacs.xml";
+    auto tixiRet = tixiOpenDocument(filename, &tixi_h);
+    ASSERT_EQ (tixiRet, SUCCESS);
+    tixiRet = tixiCreateElement(tixi_h, "/cpacs/vehicles/aircraft/model/wings/wing[1]/segments/segment[1]", "guideCurves");
+    ASSERT_EQ (tixiRet, SUCCESS);
+
+    // open with tigl and try to build segment loft
+    auto tiglRet = tiglOpenCPACSConfiguration(tixi_h, "Cpacs2Test", &tigl_h);
+    ASSERT_EQ(tiglRet, TIGL_SUCCESS);
+
+
+    tigl::CCPACSConfigurationManager& manager = tigl::CCPACSConfigurationManager::GetInstance();
+    tigl::CCPACSConfiguration& config = manager.GetConfiguration(tigl_h);
+    tigl::CCPACSWing& wing = config.GetWing(1);
+    tigl::CCPACSWingSegment& segment1 = wing.GetSegment(1);
+    segment1.GetLoft();
+}