Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to C++17 standard #1045

Merged
merged 2 commits into from
Dec 18, 2024
Merged

Update to C++17 standard #1045

merged 2 commits into from
Dec 18, 2024

Conversation

svengoldberg
Copy link
Contributor

@svengoldberg svengoldberg commented Dec 18, 2024

Description

This PR updates the C++ standard to 17 to make use of newer coding features.
Moreover, the standard was also defined in the src/CMakeLists.txt which seems redundant. Now, the C++ standard only needs to be defined in the <ROOT>/CMakeLists.txt.

Task Finished Reviewer Approved
At least one test for the new functionality was added.
  • yes
  • does not apply
  • OK
New classes have been added to the Python interface.
  • yes
  • does not apply
  • OK
The code is properly documented with doxygen docstrings
  • yes
  • does not apply
  • OK
Changes are documented at the top of ChangeLog.md
  • yes
  • does not apply
  • OK

Copy link

codecov bot commented Dec 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 69.47%. Comparing base (c5ccbb2) to head (0d8b557).
Report is 3 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1045   +/-   ##
=======================================
  Coverage   69.47%   69.47%           
=======================================
  Files         301      301           
  Lines       26889    26887    -2     
=======================================
  Hits        18681    18681           
+ Misses       8208     8206    -2     
Flag Coverage Δ
unittests 69.47% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

@svengoldberg svengoldberg merged commit 4adb704 into master Dec 18, 2024
17 checks passed
@svengoldberg svengoldberg deleted the 1044_CXX_17_update branch December 18, 2024 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants