problem_setting: speed up int validation #166
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Integer validation via regex is unfortunately very slow. For now, regex validation for floats will be kept, since custom validation would be very cumbersome, and problems with floats usually have high overhead regardless.
kiritofeng
reviewed
Dec 30, 2024
| if (i < token.size() && token[i] == '-') { | ||
| ++i; | ||
| } | ||
| if (i >= token.size() || token[i] < '1' || '9' < token[i]) { |
There was a problem hiding this comment.
Maybe you should explicitly note that -0 is not a valid int, just in case some language considers it separate from 0.
There was a problem hiding this comment.
This caveat is already in the documentation for readInt, should we add it here as a comment as well? I think the documentation is likely sufficient.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Integer validation via regex is unfortunately very slow. For now, regex validation for floats will be kept, since custom validation would be very cumbersome, and problems with floats usually have high overhead regardless.