Replace cspice calls with spiceql and add api accessor function #5545

AustinSanders · 2024-07-12T22:32:53Z

Description

Sets the stage for removing cspice calls that interact directly with kernels. Uses "restincurl" to provide api access.

In order to get this merged, I'll need to:

Replace the remaining cspice calls
Write tests
Address inline TODOs (exception handling, etc.)
Edit xml/UI to include "useWeb" for appropriate applications

Related Issue

How Has This Been Validated?

Types of changes

Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Documentation change (update to the documentation; no code change)
Breaking change (fix or feature that would cause existing functionality to change)
Infrastructure change (changes to things like CI or the build system that do not impact users)

Checklist:

I have read and agree to abide by the Code of Conduct
I have read the CONTRIBUTING document.
My change requires a change to the documentation and I have updated the documentation accordingly.
I have added tests to cover my changes.
I have added myself to the .zenodo.json document.
I have added my user impacting change to the CHANGELOG.md document.

Licensing

This project is mostly composed of free and unencumbered software released into the public domain, and we are unlikely to accept contributions that are not also released into the public domain. Somewhere near the top of each file should have these words:

This work is free and unencumbered software released into the public domain. In jurisdictions that recognize copyright laws, the author or authors of this software dedicate any and all copyright interest in the software to the public domain.

I dedicate any and all copyright interest in this software to the public domain. I make this dedication for the benefit of the public at large and to the detriment of my heirs and successors. I intend this dedication to be an overt act of relinquishment in perpetuity of all present and future rights to this software under copyright law.

github-actions · 2024-08-05T19:15:21Z

The build and test suite have started for your pull request.

To view your build log, please reference the build with source version: "PR_5545".

Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch.

github-actions · 2024-08-05T19:19:12Z

The build and test suite have started for your pull request.

To view your build log, please reference the build with source version: "PR_5545".

Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch.

github-actions · 2024-08-08T18:16:56Z

The build and test suite have started for your pull request.

To view your build log, please reference the build with source version: "PR_5545".

Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch.

github-actions · 2024-08-09T18:22:01Z

The build and test suite have started for your pull request.

To view your build log, please reference the build with source version: "PR_5545".

Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch.

github-actions · 2024-12-09T16:49:23Z

The build and test suite have started for your pull request.

To view your build log, please reference the build with source version: "PR_5545".

Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch.

github-actions · 2024-12-09T18:11:49Z

The build and test suite have started for your pull request.

To view your build log, please reference the build with source version: "PR_5545".

Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch.

github-actions · 2024-12-09T18:28:14Z

The build and test suite have started for your pull request.

To view your build log, please reference the build with source version: "PR_5545".

Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch.

github-actions · 2024-12-09T18:41:18Z

The build and test suite have started for your pull request.

To view your build log, please reference the build with source version: "PR_5545".

Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch.

github-actions · 2024-12-09T19:11:42Z

The build and test suite have started for your pull request.

To view your build log, please reference the build with source version: "PR_5545".

Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch.

github-actions · 2024-12-09T19:43:29Z

The build and test suite have started for your pull request.

To view your build log, please reference the build with source version: "PR_5545".

Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch.

github-actions · 2024-12-09T20:00:23Z

The build and test suite have started for your pull request.

To view your build log, please reference the build with source version: "PR_5545".

Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch.

github-actions · 2024-12-09T20:11:54Z

The build and test suite have started for your pull request.

To view your build log, please reference the build with source version: "PR_5545".

Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch.

github-actions · 2024-12-09T21:36:58Z

The build and test suite have started for your pull request.

To view your build log, please reference the build with source version: "PR_5545".

Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch.

github-actions · 2024-12-09T22:08:27Z

The build and test suite have started for your pull request.

To view your build log, please reference the build with source version: "PR_5545".

Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch.

github-actions · 2024-12-10T21:48:00Z

The build and test suite have started for your pull request.

To view your build log, please reference the build with source version: "PR_5545".

Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch.

github-actions · 2024-12-13T17:46:47Z

The build and test suite have started for your pull request.

To view your build log, please reference the build with source version: "PR_5545".

Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch.

github-actions · 2024-12-17T19:37:04Z

The build and test suite have started for your pull request.

To view your build log, please reference the build with source version: "PR_5545".

Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch.

AustinSanders · 2024-12-17T21:06:01Z

isis/src/base/objs/RestfulSpice/RestfulSpice.cpp

@@ -120,7 +120,7 @@ namespace Isis::RestfulSpice{
          {"spkQuality", spkQuality}
          });
      // @TODO check that json exists / contains what we're looking for
-      json out = spiceAPIQuery("getTargetStates", args, "POST");


Just as a heads up -- the "POST" here was necessary for images with a lot of state information. On small images, "GET" works fine, but many times the kernel set will exceed the maximum size of GET requests.

Curious, were you able to test the POST call with a heavy payload? ISIS tests that incurred getTargetStates and getTargetOrientations calls seemed to fail until the call method was changed to GET.

There's a sibling PR on SpiceQL that includes fixes necessary to get this working. I'm not sure how to easily tie those changes into CI, though.

With those changes in place, local tests passed with both small and large kernel sets.

github-actions · 2025-01-08T19:18:23Z

The build and test suite have started for your pull request.

To view your build log, please reference the build with source version: "PR_5545".

Additionally, check the latest "dev" source version to identify existing test failures. Please note that you are not responsible for the test failures that exist on both your PR and the dev branch.

AustinSanders added 4 commits August 5, 2024 13:10

Added findspiceql to build system

e7ea906

Added spiceql

cb14607

Initial isis/spiceql wrapped functions

972f7ef

added todo

247a80e

AustinSanders force-pushed the web_spice_calls branch from 69a7f76 to 247a80e Compare August 5, 2024 19:14

merge dev

0886b15

AustinSanders added 18 commits August 8, 2024 12:04

Replaced apollopaninit cspice calls with spiceql

8b76f4f

Updated local spice calls with searchkernels=true

5e09e3e

Replaced voyager2isis cspice calls with spiceql calls

3a3bb84

Replaced vikcal calparameters cspice calls with spiceql calls

75b0c53

Updated rosvirtis2isis cspice calls with spiceql calls

3915b69

Replaced newhorizons cspice calls with spiceql calls

aa1c94b

Replaced lronaccal cspice calls with spiceql calls

394db88

Replaced chan1m32isis cspice calls with spiceql calls

79ab710

Replaced gllssical cspice calls with spiceql calls

e563133

Replaced lrowaccal cspice calls with spiceql calls

5177066

Replaced amicacal cspice calls with spiceql calls

ead2f55

Replaced hicalconf cspice calls with spiceql calls

2a4930e

Add spiceql to environment

e2494b5

Replaced mical cspice calls with spiceql calls

b2df938

Replaced moccal cspice calls with spiceql calls

5585fe7

Replaced moclabels cspice calls with spiceql calls

b982070

Replaced ctxcal cspice calls with spiceql calls

a0ba457

Replaced hijitcube cspice calls with spiceql calls

ab42c15

Replaced sumfinder cspice calls with spiceql calls

d1a8efe

Removed unused variables and added TODO

320c937

Update spiceql path_suffix

70281f8

Update spiceql library name

9c49f15

Change SpiceQL.h to spiceql.h

67f7a6a

Remove KernelPool

7474fb2

chkim-usgs force-pushed the web_spice_calls branch from c4d4a4b to 7474fb2 Compare December 9, 2024 19:42

Remove KernelPool

579bb2b

Remove KernelPool in shadow

f43f45d

Remove false bools in apollopaninit

dd4c67d

Movie Isis import to top

8f4c340

Replace furnsh_c with load

aef3de8

Replace base in sumspice

b224fd3

chkim-usgs added 3 commits December 13, 2024 16:48

Replace post with get calls

a4727bc

Lowercase mars

32b47dc

Turn off web spice for tests

8dfdcba

AustinSanders commented Dec 17, 2024

View reviewed changes

Test fixes

a44a2d9

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Replace cspice calls with spiceql and add api accessor function #5545

Replace cspice calls with spiceql and add api accessor function #5545

AustinSanders commented Jul 12, 2024 •

edited

Loading

github-actions bot commented Aug 5, 2024

github-actions bot commented Aug 5, 2024

github-actions bot commented Aug 8, 2024

github-actions bot commented Aug 9, 2024

github-actions bot commented Dec 9, 2024

github-actions bot commented Dec 9, 2024

github-actions bot commented Dec 9, 2024

github-actions bot commented Dec 9, 2024

github-actions bot commented Dec 9, 2024

github-actions bot commented Dec 9, 2024

github-actions bot commented Dec 9, 2024

github-actions bot commented Dec 9, 2024

github-actions bot commented Dec 9, 2024

github-actions bot commented Dec 9, 2024

github-actions bot commented Dec 10, 2024

github-actions bot commented Dec 13, 2024

github-actions bot commented Dec 17, 2024

AustinSanders Dec 17, 2024 •

edited

Loading

chkim-usgs Dec 17, 2024

AustinSanders Dec 17, 2024 •

edited

Loading

github-actions bot commented Jan 8, 2025

Replace cspice calls with spiceql and add api accessor function #5545

Are you sure you want to change the base?

Replace cspice calls with spiceql and add api accessor function #5545

Conversation

AustinSanders commented Jul 12, 2024 • edited Loading

Description

Related Issue

How Has This Been Validated?

Types of changes

Checklist:

Licensing

github-actions bot commented Aug 5, 2024

github-actions bot commented Aug 5, 2024

github-actions bot commented Aug 8, 2024

github-actions bot commented Aug 9, 2024

github-actions bot commented Dec 9, 2024

github-actions bot commented Dec 9, 2024

github-actions bot commented Dec 9, 2024

github-actions bot commented Dec 9, 2024

github-actions bot commented Dec 9, 2024

github-actions bot commented Dec 9, 2024

github-actions bot commented Dec 9, 2024

github-actions bot commented Dec 9, 2024

github-actions bot commented Dec 9, 2024

github-actions bot commented Dec 9, 2024

github-actions bot commented Dec 10, 2024

github-actions bot commented Dec 13, 2024

github-actions bot commented Dec 17, 2024

AustinSanders Dec 17, 2024 • edited Loading

Choose a reason for hiding this comment

chkim-usgs Dec 17, 2024

Choose a reason for hiding this comment

AustinSanders Dec 17, 2024 • edited Loading

Choose a reason for hiding this comment

github-actions bot commented Jan 8, 2025

AustinSanders commented Jul 12, 2024 •

edited

Loading

AustinSanders Dec 17, 2024 •

edited

Loading

AustinSanders Dec 17, 2024 •

edited

Loading