-
Notifications
You must be signed in to change notification settings - Fork 441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Accessibility] Solve front page text and color contrast issues #3810
Comments
Good afternoon @hostle83! We at Neki-it would like to contribute in some way to solving this problem. We've done some tests and would like to know if this looks good to you. If you'd like to suggest any changes, we'd be happy to help. |
Good afternoon, @Andrea-Guevara! Thank you very much for your message. This might just be me, but I am unable to see a difference between the image you shared and the screenshot in the initial bug report above. Would you please be so kind and point me in the right direction here? Thank you! |
Good morning @hostle83! I understand, it's a bit hard to tell the difference. We've made a pull available for you to test. If necessary, we're happy to change anything. If this change still isn't good enough, one thing we could do is increase the font size! |
Hi @Andrea-Guevara, thank you! I was able to check out the PR and test it and it looks much better indeed! However, I am still receiving color contrast issues when running accessibility checks in Silktide. With your PR, the contrast improves from 3.36:1 to 3.95:1. The goal is to reach 4.5:1. I use Silktide to get an accurate measure of color contrast. It's a free Chrome extension. Please let me know if you have any questions! |
Good afternoon @hostle83! I was able to use the accessibility tool you are using. I think it's for real now. The green color of the text was not in good contrast so I lightened it trying to keep the shade of green a bit. We're open to suggestions! |
Good morning, @Andrea-Guevara! Excellent, it passes all checks now, well done and thank you! |
Describe the bug
There are a lot of color contrast issues on the front page of the DSpace Demo instance.
To Reproduce
Steps to reproduce the behavior:
Go to the DSpace Demo Site and, using a color contrast tool, such as Silktide, check the color contrasts for the text against the image.
Expected behavior
Increase color contrast by blurring the image further, by making it darker, and/or by altering the text (font color, font size, style, etc.)
Related work
Related to #3809
The text was updated successfully, but these errors were encountered: