Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improving the color contrast of home news content #3880

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Improving the color contrast of home news content #3880

wants to merge 2 commits into from

Conversation

Andrea-Guevara
Copy link
Contributor

References

Description

Improved color contrast of home news content.

Instructions for Reviewers

List of changes in this PR:

  • In the “home-news.component” component, the font weight has been increased,
  • In the style file “_theme_css_variable_overrides.scss” the banner has been darkened a little.

Use an accessibility tool to see if the home news content is more accessible.

Checklist

  • My PR is created against the main branch of code (unless it is a backport or is fixing an issue specific to an older branch).
  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR passes ESLint validation using npm run lint
  • My PR doesn't introduce circular dependencies (verified via npm run check-circ-deps)
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • My PR aligns with Accessibility guidelines if it makes changes to the user interface.
  • My PR uses i18n (internationalization) keys instead of hardcoded English text, to allow for translations.
  • My PR includes details on how to test it. I've provided clear instructions to reviewers on how to successfully test this fix or feature.
  • If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
  • If my PR fixes an issue ticket, I've linked them together.

@tdonohue tdonohue added bug accessibility 1 APPROVAL pull request only requires a single approval to merge port to dspace-7_x This PR needs to be ported to `dspace-7_x` branch for next bug-fix release port to dspace-8_x This PR needs to be ported to `dspace-8_x` branch for next bug-fix release labels Jan 22, 2025
@tdonohue tdonohue added this to the 9.0 milestone Jan 22, 2025
hostle83
hostle83 approved these changes Jan 23, 2025
View reviewed changes
Copy link

@hostle83 hostle83 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Tested this and it looks good, thank you @Andrea-Guevara!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hostle83 hostle83 hostle83 approved these changes

At least 1 approving review is required to merge this pull request.

Assignees

@Andrea-Guevara Andrea-Guevara

Labels
1 APPROVAL pull request only requires a single approval to merge accessibility bug port to dspace-7_x This PR needs to be ported to `dspace-7_x` branch for next bug-fix release port to dspace-8_x This PR needs to be ported to `dspace-8_x` branch for next bug-fix release
Projects
DSpace 9.0 Release
Status: 🙋 Needs Reviewers Assigned
Milestone
9.0
Development

Successfully merging this pull request may close these issues.

[Accessibility] Solve front page text and color contrast issues
3 participants
@Andrea-Guevara @hostle83 @tdonohue