-
Notifications
You must be signed in to change notification settings - Fork 441
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issue where scoped browse by would not inititialze correct component #3845
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @jensvannerum ! Just tested it, everything works fine now!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Thanks @jensvannerum ! Merging based on test by @toniprieto (thanks as well!). Code looks good to me
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin dspace-7_x
git worktree add -d .worktree/backport-3845-to-dspace-7_x origin/dspace-7_x
cd .worktree/backport-3845-to-dspace-7_x
git switch --create backport-3845-to-dspace-7_x
git cherry-pick -x 32fae27c7a34297e16cab7f01c37064bd9ed1ba0 |
Successfully created backport PR for |
@jensvannerum : This appears to have failed backport to |
References
Description
Makes sure the browse-by-switcher component picks up changes in browse type, so the component gets rendered correctly
Instructions for Reviewers
Please add a more detailed description of the changes made by your PR. At a minimum, providing a bulleted list of changes in your PR is helpful to reviewers.
Test that switching between all types of browses works, both for scoped and non scoped browse pages
Checklist
This checklist provides a reminder of what we are going to look for when reviewing your PR. You do not need to complete this checklist prior creating your PR (draft PRs are always welcome).
However, reviewers may request that you complete any actions in this list if you have not done so. If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!
main
branch of code (unless it is a backport or is fixing an issue specific to an older branch).npm run lint
npm run check-circ-deps
)package.json
), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.