Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SCSS cleanup: remove duplicated line #3872

Merged
merged 1 commit into from
Jan 21, 2025

Conversation

saschaszott
Copy link
Contributor

Description

This PR removes the duplicated line

--bs-table-dark-color: #{$table-dark-color};

in _bootstrap_variables_mapping.scss.

@tdonohue tdonohue added code task 1 APPROVAL pull request only requires a single approval to merge port to dspace-7_x This PR needs to be ported to `dspace-7_x` branch for next bug-fix release port to dspace-8_x This PR needs to be ported to `dspace-8_x` branch for next bug-fix release labels Jan 21, 2025
@tdonohue tdonohue added this to the 9.0 milestone Jan 21, 2025
Copy link
Member

@tdonohue tdonohue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Good find, @saschaszott ! This looks correct as I see that same code on line 217

@tdonohue tdonohue merged commit 0a5d20e into DSpace:main Jan 21, 2025
15 checks passed
@dspace-bot
Copy link
Contributor

Successfully created backport PR for dspace-7_x:

@dspace-bot
Copy link
Contributor

Successfully created backport PR for dspace-8_x:

@tdonohue tdonohue removed port to dspace-7_x This PR needs to be ported to `dspace-7_x` branch for next bug-fix release port to dspace-8_x This PR needs to be ported to `dspace-8_x` branch for next bug-fix release labels Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 APPROVAL pull request only requires a single approval to merge code task
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

3 participants