Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Post dspace-7_x] Restrict Angular SSR to paths in the sitemap #3879

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

alanorth
Copy link
Contributor

@alanorth alanorth commented Jan 22, 2025

Manual port of #3682 to DSpace 7.6.x.

There are minor differences due to a refactoring of the Universal preboot configuration to "SSR" in DSpace 8 and main.

Because Angular SSR is not very efficient, after discussion with
the Google Scholar team we realized a compromise would be to only
use SSR for pages in the DSpace sitemap (and the home page).
@alanorth alanorth added bug high priority performance / caching Related to performance, caching or embedded objects labels Jan 22, 2025
@alanorth alanorth added this to the 7.6.3 milestone Jan 22, 2025
@tdonohue tdonohue self-requested a review January 22, 2025 14:56
Copy link
Member

@tdonohue tdonohue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks @alanorth . Code looks correct & this passes all automated tests (including the test that verifies SSR is still working on /home)

@tdonohue tdonohue merged commit 5342653 into DSpace:dspace-7_x Jan 22, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug high priority performance / caching Related to performance, caching or embedded objects
Projects
Development

Successfully merging this pull request may close these issues.

2 participants