Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix default sort and alignment issue #3881

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

YanaDePauw
Copy link
Contributor

References

Description

This PR fixes the issue with the default sort option being ignored from the discovery.xml file in the backend.
The search should now use the default if present. If not present, the first option of the list of sort options will be used instead.

This PR also contains a small fix for the vertical alignment of the com/col browse navigation text for smaller screens (smaller than 1100px).

Instructions for Reviewers

To verify that the default sort issue is fixed, perform the following steps:

  1. Make sure an easy to access discovery configuration has a default sort property set that is not the first in the list (e.g. the workspaceConfiguration configuration)
  2. Navigate to a search page using that configuration
  3. Verify that the configured default sort property is used
  4. Navigate to a different search page such as the default one
  5. Verify this still works as expected

The alignment issue can be verified on com/col pages when using a smaller screen.

Checklist

  • My PR is created against the main branch of code (unless it is a backport or is fixing an issue specific to an older branch).
  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR passes ESLint validation using npm run lint
  • My PR doesn't introduce circular dependencies (verified via npm run check-circ-deps)
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • My PR aligns with Accessibility guidelines if it makes changes to the user interface.
  • My PR uses i18n (internationalization) keys instead of hardcoded English text, to allow for translations.
  • My PR includes details on how to test it. I've provided clear instructions to reviewers on how to successfully test this fix or feature.
  • If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
  • If my PR fixes an issue ticket, I've linked them together.

@tdonohue tdonohue added bug 1 APPROVAL pull request only requires a single approval to merge port to dspace-7_x This PR needs to be ported to `dspace-7_x` branch for next bug-fix release port to dspace-8_x This PR needs to be ported to `dspace-8_x` branch for next bug-fix release component: Discovery related to discovery search or browse system labels Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 APPROVAL pull request only requires a single approval to merge bug component: Discovery related to discovery search or browse system port to dspace-7_x This PR needs to be ported to `dspace-7_x` branch for next bug-fix release port to dspace-8_x This PR needs to be ported to `dspace-8_x` branch for next bug-fix release
Projects
Status: 🙋 Needs Reviewers Assigned
Development

Successfully merging this pull request may close these issues.

value of defaultSortField in discovery.xml is not considered as default sort field
3 participants