Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Port main] Exclude search and browse from Angular SSR (#3709) #3886

Merged
merged 1 commit into from
Jan 23, 2025
Merged

[Port main] Exclude search and browse from Angular SSR (#3709) #3886

merged 1 commit into from
Jan 23, 2025

Conversation

tdonohue
Copy link
Member

Manual port of #3709 by @FrancescoMolinaro to main

@FrancescoMolinaro @tdonohue
Exclude search and browse from Angular SSR (DSpace#3709)
17ecc59 
* [DURACOM-303] prevent possibly long-lasting search and browse calls in SSR

* [DURACOM-303] implement skeleton component for search results

* [DURACOM-303] add skeleton loader for search results and filters

* [DURACOM-303] minor restyle of skeleton for mobile

* [DURACOM-303] fix lint and tests

* [DURACOM-303] adapt tests

* [DURACOM-303] restyle skeleton, add filter badge skeleton

* [DURACOM-303] add loop for filters count

* [DURACOM-303] add grid layout, make SSR enabling configurable, minor restyle of skeletons

* [DURACOM-303] refactor param, add example of configuration

* [DURACOM-303] rename variable, minor code refactor

* [DURACOM-303] add override possibility with input

* [DURACOM-303] fix SSR check on template and on components missing the environment config. Add descriptive comment for skeleton component. Fix JS error on SSR.

* [DURACOM-303] refactor thumbnail's skeleton style
@tdonohue tdonohue added high priority performance / caching Related to performance, caching or embedded objects 1 APPROVAL pull request only requires a single approval to merge labels Jan 23, 2025
@tdonohue tdonohue added this to the 9.0 milestone Jan 23, 2025
@tdonohue tdonohue mentioned this pull request Jan 23, 2025
Merged
12 tasks
tdonohue
tdonohue commented Jan 23, 2025
View reviewed changes
Copy link
Member Author

@tdonohue tdonohue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Manually tested that this is working on main, and it is.

@tdonohue tdonohue merged commit 63c9874 into DSpace:main Jan 23, 2025
15 checks passed
@tdonohue tdonohue deleted the port_3709_to_main branch January 23, 2025 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@tdonohue tdonohue

Labels
1 APPROVAL pull request only requires a single approval to merge high priority performance / caching Related to performance, caching or embedded objects
Projects
DSpace 9.0 Release
Status: ✅ Done
Milestone
9.0
Development

Successfully merging this pull request may close these issues.
2 participants
@tdonohue @FrancescoMolinaro