Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed search page still returning stale data after invalidating a request #3888

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

alexandrevryghem
Copy link
Member

Description

Fixed problem with the SearchService methods that could return stale data. This was fixed in the same way as BaseDataService was applied here to prevent outdated data from being emitted.

Instructions for Reviewers

List of changes in this PR:

  • Added a skipWhile method to both the search & getFacetValuesFor to skip stale data and to ignore non stale data when useCachedVersionIfAvailable is true
  • Cleaned up the SearchService test class

Guidance for how to test or review your PR:

Checklist

  • My PR is created against the main branch of code (unless it is a backport or is fixing an issue specific to an older branch).
  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR passes ESLint validation using npm run lint
  • My PR doesn't introduce circular dependencies (verified via npm run check-circ-deps)
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • My PR aligns with Accessibility guidelines if it makes changes to the user interface.
  • My PR uses i18n (internationalization) keys instead of hardcoded English text, to allow for translations.
  • My PR includes details on how to test it. I've provided clear instructions to reviewers on how to successfully test this fix or feature.
  • If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
  • If my PR fixes an issue ticket, I've linked them together.

…ad of waiting for non-stale response

This was problematic for the places that used getFist operators. This is because they only emit data once, and the first value could be the old cached value
@alexandrevryghem alexandrevryghem added bug component: Discovery related to discovery search or browse system performance / caching Related to performance, caching or embedded objects port to dspace-7_x This PR needs to be ported to `dspace-7_x` branch for next bug-fix release port to dspace-8_x This PR needs to be ported to `dspace-8_x` branch for next bug-fix release labels Jan 23, 2025
@alexandrevryghem alexandrevryghem added this to the 9.0 milestone Jan 23, 2025
@alexandrevryghem alexandrevryghem self-assigned this Jan 23, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug component: Discovery related to discovery search or browse system performance / caching Related to performance, caching or embedded objects port to dspace-7_x This PR needs to be ported to `dspace-7_x` branch for next bug-fix release port to dspace-8_x This PR needs to be ported to `dspace-8_x` branch for next bug-fix release
Projects
Status: 🙋 Needs Reviewers Assigned
Development

Successfully merging this pull request may close these issues.

1 participant