Fixed search page still returning stale data after invalidating a request #3888
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed problem with the
SearchService
methods that could return stale data. This was fixed in the same way asBaseDataService
was applied here to prevent outdated data from being emitted.Instructions for Reviewers
List of changes in this PR:
skipWhile
method to both thesearch
&getFacetValuesFor
to skip stale data and to ignore non stale data whenuseCachedVersionIfAvailable
istrue
SearchService
test classGuidance for how to test or review your PR:
Checklist
main
branch of code (unless it is a backport or is fixing an issue specific to an older branch).npm run lint
npm run check-circ-deps
)package.json
), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.