Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(frontend): configure Remix plugin optimizeDeps entries #2617

Merged
merged 1 commit into from
Nov 22, 2024

Conversation

sebastien-comeau
Copy link
Contributor

Description

Configure Remix plugin optimizeDeps entries since there's a bug on Windows. Generated path on Windows has \ and it's not working with tinyglobby at the moment which is used by Vite.

Related Azure Boards Work Items

Screenshots (if applicable)

Checklist

  • I have tested the changes locally
  • I have updated the documentation if necessary
  • I have added/updated tests that prove my fix is effective or that my feature works
  • I have checked that my code follows the project's coding style by running npm run format:check
  • I have checked that my code contains no linting errors by running npm run lint
  • I have checked that my code contains no type errors by running npm run typecheck
  • I have checked that all unit tests pass by running npm run test:unit -- run
  • I have checked that all e2e tests pass by running npm run test:e2e

Test Instructions

Additional Notes

@sebastien-comeau sebastien-comeau force-pushed the seb/fix-remix-plugin-entires branch from 6ba631b to 5ed3168 Compare November 22, 2024 17:02
@sebastien-comeau sebastien-comeau merged commit a1dd2d0 into main Nov 22, 2024
2 checks passed
@sebastien-comeau sebastien-comeau deleted the seb/fix-remix-plugin-entires branch November 22, 2024 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants