Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Text, Heading Component #29

Open
DaleSeo opened this issue Jan 6, 2025 · 2 comments · May be fixed by #30
Open

Text, Heading Component #29

DaleSeo opened this issue Jan 6, 2025 · 2 comments · May be fixed by #30
Assignees
@DaleSeo

Comments

@DaleSeo
Copy link
Contributor

DaleSeo commented Jan 6, 2025 •
edited
Loading

컴포넌트 API

  • 일반 텍스트를 위한 <Text/> 컴포넌트와 헤딩 테스트를 위한 <Heading/> 컴포넌트로 구분
  • Truncatoin이나 Line Clamp와 같은 고급 기능은 1차 구현에서는 제외

Text, Heaindg 컴포넌트 공통 props

  • children: 텍스트
  • size: fontSizes 토큰
  • wieght: fontWeights 토큰

Text 컴포넌트 props

  • as: p, span, ...

Heading 컴포넌트 props

  • level: 1, 2, 3, 4, 5, 6
@DaleSeo DaleSeo self-assigned this Jan 6, 2025
@DaleSeo
Copy link
Contributor Author

DaleSeo commented Jan 6, 2025

@nhistory 우선 요 정도로 rough하게 요구사항을 정의하고 구현을 시작해보려고 하는데 피드백 있으시면 부탁드립니다 :)

@nhistory
Copy link

nhistory commented Jan 6, 2025

좋은 것 같습니다!

@DaleSeo DaleSeo linked a pull request Jan 7, 2025 that will close this issue
Heading 컴포넌트 #30
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@DaleSeo DaleSeo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Heading 컴포넌트 DaleStudy/dale-ui
2 participants
@DaleSeo @nhistory