Heading 컴포넌트 #30
Open
Heading 컴포넌트 #30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DaleSeo
commented
Jan 10, 2025
| /** 굵기 */ | ||
| weight?: FontWeight; | ||
| /** 명암비 */ | ||
| muted?: boolean; |
There was a problem hiding this comment.
원래 contrast: "low" | "high" 였는데 API를 살짝 바꾸었습니다. 좀 더 사용자 친화적일 것이라 생각합니다.
| contrast: { | ||
| DEFAULT: { |
There was a problem hiding this comment.
명암비가 높은 글자색을 훨씬 더 많이 사용할 것 같아서, 디폴트 글자색을 바꾸었습니다.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Heading 컴포넌트를 구현하였습니다.