[아현] WEEK02 Solutions #349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
f-exuan21
commented
Aug 19, 2024
•
f-exuan21
commented
- Valid Anagram
- Counting Bits
- Encode and Decode Strings
- Construct Binary Tree From Preorder And Inorder Traversal
- Decode Ways
There was a problem hiding this comment.
charArray가 반복문을 위해서만 사용된 것 같아서
charArray를 생성하지 않고 chatAt을 이용하면 공간복잡도를 O(1)으로 푸는 것도 가능할 것 같은데 어떻게 생각하실까요?
추가적으로 n 이 무엇을 의미하는 걸까요?
There was a problem hiding this comment.
n 은 문자열의 길이를 나타냅니다.
말씀하신 데로 charAt을 쓰면 sToChar와 tToChar 를 사용하지 않아도 되어서 공간복잡도가 O(1)로 끝날 수 있어서 좋은 선택지인 것 같습니다! 👍
Counting bits solutions
주석 추가
공간복잡도를 O(n) -> O(1) 로 로직 변경
construct binary tree solutions
DaleSeo
reviewed
Aug 21, 2024
Comment on lines
+23
to
+24
| private int i = 0; | ||
| Map<Integer, Integer> map = new HashMap<>(); |
There was a problem hiding this comment.
nit: 접근 제한자를 일관적으로 붙이거나 생략해주면 불필요한 오해의 소지를 없앨 수 있을 것 같아요.
Suggested change
| private int i = 0; | |
| Map<Integer, Integer> map = new HashMap<>(); | |
| private int i = 0; | |
| private Map<Integer, Integer> map = new HashMap<>(); |
sun912
reviewed
Aug 24, 2024
|
|
||
| return true; | ||
| } | ||
| } |
There was a problem hiding this comment.
나머지 문제도 시간 되실 때 꼭 풀어보시면 좋을것 같습니다!! 배울게 많은 문제들이었던 것 같습니다=)
DaleSeo
approved these changes
Aug 24, 2024
|
@f-exuan21 님, 본 PR 계속 Draft 상태로 두시고 병합하지 않으시는 이유가 있으신가요? |
|
@DaleSeo 아 제가 주말동안 git에 접속을 못했습니다 ㅜㅠ 병합했습니다! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.