[친환경사과] Week 3 #794
Merged
[친환경사과] Week 3 #794
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jinah92
reviewed
Dec 28, 2024
| * 공간 복잡도: O(1) | ||
| * -> 결과를 저장하는 result, 배열의 index를 가리키는 indices는 두 개의 값을 담기 때문에 O(1) | ||
| */ | ||
| fun twoSum(nums: IntArray, target: Int): IntArray { |
There was a problem hiding this comment.
배열 대신에 key, value 값으로 메모이제이션을 활용해서 시간 복잡도를 줄이는 방법도 고민해보면 좋을 거 같습니다~
입력 nums 파라미터를 한번만 순회하면서 요소값을 key로, 요소의 인덱스를 value로 저장할 수 있지 않을까요?
jinah92
reviewed
Dec 28, 2024
| result = (result shl 1) or (input and 1) | ||
| // 입력 비트를 오른쪽으로 이동 | ||
| input = input shr 1 | ||
| } |
There was a problem hiding this comment.
코틀린에는 shl, shr을 통해 비트이동이 가능하네요, 좋은 지식 하나 알고 갑니다^^
jinah92
reviewed
Dec 28, 2024
| val eachBitValue = 2.0.pow(i).toInt() | ||
| if (fullBitString[i] == '0') { | ||
| continue | ||
| } else { |
There was a problem hiding this comment.
26라인의 코드는 if 조건을 타지 않는 경우에 모두 실행되기 때문에,
가독성 측면에서 굳이 else 범위를 정의하지 않아도 되보입니다
There was a problem hiding this comment.
if (fullBitString[i] == '1') result += eachBitValue
로 가독성 높게 구현할 수 있겠네요! 감사합니다.!
jinah92
approved these changes
Dec 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
답안 제출 문제
체크 리스트
In Review로 설정해주세요.