Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: parse_robots_txt #205

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Fix: parse_robots_txt #205

wants to merge 2 commits into from

Conversation

arielnlee
Copy link
Collaborator

Fixes the issues raised by: #203

  1. Grouping of lines / rules
  2. Case insensitive syntax
  3. Ignore comments, new lines

also general formatting clean up.

@arielnlee arielnlee self-assigned this Jan 7, 2025
@arielnlee arielnlee marked this pull request as draft January 7, 2025 03:31
@arielnlee arielnlee changed the title fix parse_robots_txt Fix: parse_robots_txt Jan 7, 2025
Copy link
Contributor

@shayne-longpre shayne-longpre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- is it worth adding a couple unit tests to https://github.com/Data-Provenance-Initiative/Data-Provenance-Collection/blob/main/src/web_analysis/test_robots.py and testing everything else still passes too?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants