Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix buildx pipeline for Darwin binary/image #258

Merged
merged 1 commit into from
Sep 12, 2024
Merged

Fix buildx pipeline for Darwin binary/image #258

merged 1 commit into from
Sep 12, 2024

Conversation

jt-dd
Copy link
Contributor

@jt-dd jt-dd commented Sep 12, 2024 •
edited by Minosity-VR
Loading

Removing DWARF symbol on Darwin as it causes the following error:

/usr/local/go/pkg/tool/linux_arm64/link: /usr/local/go/pkg/tool/linux_arm64/link: running dsymutil failed: exec: "dsymutil": executable file not found in $PATH

So striping the DWARF symbol just for the Darwin Binary.

@jt-dd jt-dd marked this pull request as ready for review September 12, 2024 11:59
@jt-dd jt-dd requested a review from a team as a code owner September 12, 2024 11:59
Minosity-VR
Minosity-VR approved these changes Sep 12, 2024
View reviewed changes
Copy link
Contributor

@Minosity-VR Minosity-VR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add in the description the source where you found that the issue was linked to the -w option? Or if it was just trial and error since previous change that removed those flags?

@jt-dd jt-dd merged commit 5135194 into main Sep 12, 2024
8 checks passed
@jt-dd jt-dd deleted the jt-dd/fix-builx-darwin branch September 12, 2024 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Minosity-VR Minosity-VR Minosity-VR approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jt-dd @Minosity-VR