-
Notifications
You must be signed in to change notification settings - Fork 49
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
graphdb batch writer resiliency #295
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently not working as the async synchro is not properly done. Also maybe adding a dedicated function to add element into the queue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice. LTGM, can you add to the reference configuration file with the default value ?
Context
The graphdb entity writers can be subject to unexpected behaviours from the JanusGraph backend (eg. backend not responding due to runtine errors).
The writers have been modified to add resilience to unexpected situation:
Sample warning triggering a retry with split batch after a unresponsive backend issue:
The batcher settings has been updated to reflect this new state:
500
->250
KH_BUILDER_VERTEX_BATCH_SIZE
/KH_BUILDER_EDGE_BATCH_SIZE
env. variablesbuilder.egde/vertex.batch_size
config key1
->10
KH_JANUSGRAPH_WRITER_WORKER_COUNT
janusgraph.writer_worker_count
config key