feat(graph): embed MITRE Attck technique and tactic into edges #312
+780
−208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Minosity-VR
approved these changes
Jan 8, 2025
Comment on lines
+165
to
+190
| // Define properties for each edge | ||
| mgmt.addProperties(permissionDiscover, runID, attckTechniqueID, attckTacticID); | ||
| mgmt.addProperties(volumeDiscover, runID, attckTechniqueID, attckTacticID); | ||
| mgmt.addProperties(volumeAccess, runID, attckTechniqueID, attckTacticID); | ||
| mgmt.addProperties(hostWrite, runID, attckTechniqueID, attckTacticID); | ||
| mgmt.addProperties(hostRead, runID, attckTechniqueID, attckTacticID); | ||
| mgmt.addProperties(hostTraverse, runID, attckTechniqueID, attckTacticID); | ||
| mgmt.addProperties(sharedPsNamespace, runID, attckTechniqueID, attckTacticID); | ||
| mgmt.addProperties(containerAttach, runID, attckTechniqueID, attckTacticID); | ||
| mgmt.addProperties(idAssume, runID, attckTechniqueID, attckTacticID); | ||
| mgmt.addProperties(idImpersonate, runID, attckTechniqueID, attckTacticID); | ||
| mgmt.addProperties(roleBind, runID, attckTechniqueID, attckTacticID); | ||
| mgmt.addProperties(podAttach, runID, attckTechniqueID, attckTacticID); | ||
| mgmt.addProperties(podCreate, runID, attckTechniqueID, attckTacticID); | ||
| mgmt.addProperties(podPatch, runID, attckTechniqueID, attckTacticID); | ||
| mgmt.addProperties(podExec, runID, attckTechniqueID, attckTacticID); | ||
| mgmt.addProperties(tokenSteal, runID, attckTechniqueID, attckTacticID); | ||
| mgmt.addProperties(tokenBruteforce, runID, attckTechniqueID, attckTacticID); | ||
| mgmt.addProperties(tokenList, runID, attckTechniqueID, attckTacticID); | ||
| mgmt.addProperties(nsenter, runID, attckTechniqueID, attckTacticID); | ||
| mgmt.addProperties(moduleLoad, runID, attckTechniqueID, attckTacticID); | ||
| mgmt.addProperties(umhCorePattern, runID, attckTechniqueID, attckTacticID); | ||
| mgmt.addProperties(privMount, runID, attckTechniqueID, attckTacticID); | ||
| mgmt.addProperties(sysPtrace, runID, attckTechniqueID, attckTacticID); | ||
| mgmt.addProperties(varLogSymLink, runID, attckTechniqueID, attckTacticID); | ||
| mgmt.addProperties(endpointExploit, runID, attckTechniqueID, attckTacticID); |
There was a problem hiding this comment.
This looks like something that can be easily forgotten when adding additional edges. Do you think there is a way to test that all defined edges do have a property attached? something like a unit test?
There was a problem hiding this comment.
Technically, you should add entries in this file to declare your new edges and their associated properties. This file is the schema builder for JanusGraph.
I'm not aware of any existing graph schema unit tests, but I can have a look to.
jt-dd
approved these changes
Jan 8, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
gen-index.pyto support the coverage attribute.Reference(s)